Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use JAX-RS and resteasy for implementing the GitLab API #203

Closed

Conversation

coder-hugo
Copy link
Contributor

This PR replaces the java-gitlab-api dependency with an interface annotated with JAX-RS annotations that only "implement" the required methods of the GitLab API. Based on this annotated interface resteasy can create a client as a Java Proxy for the interface.
Each method invocation of this interface will end in a single HTTP call (this is different in the java-gitlab-api) which makes it more easy to test if the plugin will call the GitLab API correctly.
Fixes #212

@jenkinsadmin
Copy link
Member

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@omehegan
Copy link
Member

@coder-hugo just wondering what the status of your work on the 1.2 release is.

@coder-hugo
Copy link
Contributor Author

@omehegan I was very busy for the last 3 weeks so I hadn't any time to work on the plugin.
From my point of view the branch release-1.2 should by ready for a release. I just wanted to add some further integration tests. But they aren't necessary for a release. If I find some time this evening I'll either merge the release-1.2 branch to the current master or just make it the current master. If this is done we can do a new release.

@coder-hugo coder-hugo closed this Apr 26, 2016
exceed-alae pushed a commit to exceed-alae/gitlab-plugin that referenced this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants