Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TB_CREDENTIALS aren't properly detected #1243

Closed
DavidGOrtega opened this issue Oct 29, 2022 · 9 comments · Fixed by #1244 or #1247
Closed

TB_CREDENTIALS aren't properly detected #1243

DavidGOrtega opened this issue Oct 29, 2022 · 9 comments · Fixed by #1244 or #1247
Labels
bug Something isn't working cml-tensorboard Subcommand

Comments

@DavidGOrtega
Copy link
Contributor

DavidGOrtega commented Oct 29, 2022 •
edited
Loading

Setting TB_CREDENTIALS is not enough as credentials is now a required parameter.

cml.dev examples are fundamentally broken due to this.
@DavidGOrtega DavidGOrtega added cml-tensorboard Subcommand bug Something isn't working labels Oct 29, 2022
@0x2b3bfa0 0x2b3bfa0 mentioned this issue Oct 29, 2022
Merged
@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Oct 29, 2022 •
edited
Loading

cml.dev examples are no longer the source of truth and shall be updated; please refer to workflows on cml-examples-dev

@DavidGOrtega
Copy link
Contributor Author

cml.dev examples are no longer the source of truth and shall be updated; please refer to workflows on cml-examples-dev

Not sure what do you mean here. Both cases are broken due to this bug

@DavidGOrtega DavidGOrtega reopened this Oct 29, 2022
@DavidGOrtega
Copy link
Contributor Author

The PR #1244 does not seems to fix the issue

@dacbd
Copy link
Contributor

dacbd commented Oct 29, 2022

maybe since its marked as required yargs isn't properly detecting our injection for the env var.

@DavidGOrtega
Copy link
Contributor Author

DavidGOrtega commented Oct 29, 2022 •
edited
Loading

Yes, probably, as I stated in the PR.

@dacbd dacbd changed the title Tensorboard credentials are now required TB_CREDENTIALS aren't properly detected Oct 29, 2022
@0x2b3bfa0
Copy link
Member

Then all the legacy environment variables are broken?

@dacbd
Copy link
Contributor

dacbd commented Oct 29, 2022

Then all the legacy environment variables are broken?

I don't think that is the case, they could be populated properly but only after yargs performs its required: true validation?

@0x2b3bfa0
Copy link
Member

Then, should we run the environment variable aliasing code before calling yargs.parse to prevent this issue?

@dacbd
Copy link
Contributor

dacbd commented Oct 30, 2022

Then, should we run the environment variable aliasing code before calling yargs.parse to prevent this issue?

to me, it looks like that is already the case? but you are the resident yargs expert 😇 can we make that tweak?

@0x2b3bfa0 0x2b3bfa0 mentioned this issue Oct 30, 2022
Merged
@casperdcl casperdcl mentioned this issue Nov 1, 2022
Merged
casperdcl added a commit to iterative/cml.dev that referenced this issue Nov 1, 2022
@casperdcl
ref/ci: --fetch-depth
438d9d9 
- follow-up to iterative/cml#1246
- follow-up to iterative/cml#1243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working cml-tensorboard Subcommand
Projects
None yet
Milestone
No milestone
3 participants
@DavidGOrtega @dacbd @0x2b3bfa0