Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix environment variable aliases #1247

Merged
merged 5 commits into from
Nov 1, 2022
Merged

Fix environment variable aliases #1247

merged 5 commits into from
Nov 1, 2022

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Oct 30, 2022 •
edited
Loading

Closes #1243 unlike #1244

@0x2b3bfa0 0x2b3bfa0 added the bug Something isn't working label Oct 30, 2022
@0x2b3bfa0 0x2b3bfa0 requested a review from dacbd October 30, 2022 00:57
@0x2b3bfa0 0x2b3bfa0 self-assigned this Oct 30, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal October 30, 2022 00:57 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal October 30, 2022 00:59 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal October 30, 2022 01:06 Inactive
DavidGOrtega
DavidGOrtega previously approved these changes Oct 30, 2022
View reviewed changes
@DavidGOrtega DavidGOrtega temporarily deployed to internal October 31, 2022 20:57 Inactive
@0x2b3bfa0 0x2b3bfa0 enabled auto-merge (squash) October 31, 2022 21:09
@0x2b3bfa0 0x2b3bfa0 requested review from dacbd and removed request for dacbd October 31, 2022 21:09
@dacbd dacbd temporarily deployed to internal October 31, 2022 21:57 Inactive
@0x2b3bfa0 0x2b3bfa0 requested a review from a team October 31, 2022 22:11
dacbd
dacbd approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@dacbd dacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work for me.

@0x2b3bfa0 0x2b3bfa0 merged commit 1a2b245 into master Nov 1, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the fix-env-aliases branch November 1, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dacbd dacbd dacbd approved these changes

@DavidGOrtega DavidGOrtega DavidGOrtega left review comments

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TB_CREDENTIALS aren't properly detected
3 participants
@0x2b3bfa0 @DavidGOrtega @dacbd