Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tensorboard credentials environment variable #1244

Merged
merged 1 commit into from
Oct 29, 2022
Merged

Fix Tensorboard credentials environment variable #1244

merged 1 commit into from
Oct 29, 2022

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Oct 29, 2022 •
edited
Loading

Closes #1243

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal October 29, 2022 15:44 Inactive
dacbd
dacbd approved these changes Oct 29, 2022
View reviewed changes
Copy link
Contributor

@dacbd dacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dacbd dacbd merged commit 329ed42 into master Oct 29, 2022
@dacbd dacbd deleted the fix-tensorboard-credentials branch October 29, 2022 16:22
DavidGOrtega
DavidGOrtega suggested changes Oct 29, 2022
View reviewed changes
Copy link
Contributor

@DavidGOrtega DavidGOrtega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems not to fix it 🙁

bin/cml.js
@@ -12,7 +12,7 @@ const { jitsuEventPayload, send } = require('../src/analytics');

const setupOpts = (opts) => {
const legacyEnvironmentVariables = {
TB_CREDENTIALS: 'CML_TENSORBOARD_DEV_CREDENTIALS',
TB_CREDENTIALS: 'CML_TENSORBOARD_CREDENTIALS',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same error??

Missing required argument: credentials

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the var is now required

credentials: {
        type: 'string',
        alias: 'c',
        required: true,
        description:
          'TB credentials as json. Usually found at ~/.config/tensorboard/credentials/uploader-creds.json. If not specified will look for the json at the env variable CML_TENSORBOARD_DEV_CREDENTIALS.'
      },

@DavidGOrtega DavidGOrtega mentioned this pull request Oct 29, 2022
Closed
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Oct 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidGOrtega DavidGOrtega DavidGOrtega requested changes

@dacbd dacbd dacbd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TB_CREDENTIALS aren't properly detected
3 participants
@0x2b3bfa0 @DavidGOrtega @dacbd