Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default value for --fetch-depth #1246

Merged
merged 6 commits into from
Oct 31, 2022
Merged

Remove default value for --fetch-depth #1246

merged 6 commits into from
Oct 31, 2022

Conversation

dacbd
Copy link
Contributor

@dacbd dacbd commented Oct 29, 2022

follow-up for #1233 (review)

@dacbd dacbd temporarily deployed to internal October 29, 2022 16:54 Inactive
@dacbd dacbd requested review from casperdcl and a team and removed request for casperdcl October 29, 2022 16:54
@dacbd dacbd temporarily deployed to internal October 29, 2022 17:03 Inactive
@dacbd dacbd temporarily deployed to internal October 29, 2022 17:10 Inactive
src/cml.js Show resolved Hide resolved
0x2b3bfa0
0x2b3bfa0 previously approved these changes Oct 31, 2022
@casperdcl casperdcl temporarily deployed to internal October 31, 2022 21:31 Inactive
@casperdcl casperdcl temporarily deployed to internal October 31, 2022 21:35 Inactive
@casperdcl casperdcl requested a review from 0x2b3bfa0 October 31, 2022 21:35
Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed a couple of commits; please do check :)

@dacbd
Copy link
Contributor Author

dacbd commented Oct 31, 2022

additions work for me.

@dacbd dacbd merged commit fc9e235 into master Oct 31, 2022
@dacbd dacbd deleted the fetch-depth branch October 31, 2022 21:54
casperdcl added a commit to iterative/cml.dev that referenced this pull request Nov 1, 2022
@casperdcl casperdcl added bug Something isn't working cml-ci Subcommand p1-important High priority labels Nov 1, 2022
@casperdcl
Copy link
Contributor

Docs PR at iterative/cml.dev#364 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cml-ci Subcommand p1-important High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants