ref/ci: --fetch-depth
#364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- follow-up to iterative/cml#1246 - follow-up to iterative/cml#1243
Link Check ReportThere were no links to check!
|
0x2b3bfa0
approved these changes
Nov 1, 2022
jorgeorpinel
reviewed
Nov 1, 2022
Comment on lines
-29
to
+28
| $ cml ci | ||
| $ cml ci --fetch-depth=0 |
There was a problem hiding this comment.
Product Q: Should it be the default value?
There was a problem hiding this comment.
There is no default value for this option, Imagine that 95% of the use cases will be --fetch-depth=0 or the previous alias for this --unshallow
There was a problem hiding this comment.
--fetch-depth=0 is slow & space-consuming so can't be the default. Also, we can't use --fetch-depth=1 imitating GHA because that would truncate unshallow repos.
Safest is to have undefined (unset) default, i.e. do-nothing, but document --fetch-depth=0 as the most likely use case.
dacbd
approved these changes
Nov 1, 2022
Link Check ReportThere were no links to check! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--fetch-depthcml#1246ci --fetch-depth, deprecateci --unshallowcml#1233