Upgrade 1.0.0-rc0 -> 1.0.0 version #10

gfournieriExec · 2024-01-22T10:46:50Z

Upgraded first our master branch from omni repo -> 1.0.0-rc0 to 1.0.0.
Created this branch from suport/viviani and merged our master.
Managed to harmonize the all env variable.
Tested UI ✅
Tested one Oracle ✅

* Ultimate e2e for native to erc type of bridge * One job * Try to run the tests * Run on CI * Docs * Cosmetics * Final changes * Revert the changes * Networks * Waiting for Oracle * One job * Initialize the contracts submodule * Run on ci * comment * Sleep. * ultimate network * Docker localhost no longer needed * Final changes * Timeout * Naming * Sleep task.

* Renamed v1 abi names * Home store using v1 from commons * Using ERC20_BYTES32_ABI from commons

* Added remote logging for monitor * Legacy line * Tempaltes

* Stopped silently swallowing errors * getTokenType in commons * Oracle using getTokenType from commons * Moved the getTokenType tests from ui to commons * Using getTokenType in ui and oracle * Revert "Stopped silently swallowing errors" fc92c0a * using common getTokenType in monitor. * Lint.

* Default cron schedule * Added cron task * Docs * Overwriting log files * Removed deprecated flag * Default monitor_cron_schedule.

b532c8b

* new security audit report for the contracts v2.3.2 * contracts updated to points to latest commit

* Trying job * dependency * Run the tests * Oracle docker composes * Fixed networks * endpoints * Skip logging * Try node * Moved chromedriver from ui to ui-e2e * Port * Run * Install chrome * minte blocks * Finishing * Revert "Skip logging" 76747eb * inventory * Inventory change. * ui-e2e fix * ui-e2e fix? * native-to-erc group * jobs * Ports * Blocks * yarn * fix * fix * killall * Try ui-e2e * no killall * All jobs. * Try two * separate jobs * all jobs * One job. * Removed the oracle-e2e step in ultimate tests.

* Started working on monitor-e2e * Monitor e2e tests extended for 3 types of bridge * Skipp error checking * bash fix * Fixed docker-compose * check first * grep errors * all jobs * Style * Executing instead of sourcing

* Extend line width to 120 * Lint fixes

* Monitor deployment testing - initial commit. * deployment-monitor job * one job * Additional tests. * server port. * lint * all jobs

* Update ci config version * try to use orb * command * naming * Common docker executor config * Machine in orb * Common tasks * common caching * nvm * Final test

* Change user * jobs * Revert "Change user" 5fa7084 * Trying to use block generator address * jobs * Fixed * 5 jobs * 10 jobs * all jobs * finish * Removed jobs * Add funds for block generator in block genesis

* Common gas price normalization. * only e2e jobs * One func * More extraction. * Fixed the tests * skip gasPriceWithinLimits * test fix * tos tring * boundaries * Extracted fetching gas price from contract * Refactored oracle gas price * lint * lint * Commentary * Using common gas price from oracle in ui * Fix lint * lint * Log * Using common gas price in monitor * cosmetics * all jobs * lint * lint * tests * more tests * incljdes * Tests in oracle * Tests in commons * Lint * moved tests from ui to commons * chai * Changed order of fetching gas price

* Extracted parseValidatorEvent to commons * Extracted processValidatorsEvents to commons * Extracted validatorList to commons. * refactorings * Fixed imports, lint * UI using getValidatorList * Monitor using getValidatorList from commons * Lint * UI using properly getPastEvents * Default options * Final changes * Corrected invocation of getPastEvents * Correct usage of options in getPastEvents * Changed expected message from infura * Change usage of fromBlock and toBlock * Default parameters

* Introducing ultimate erc-to-native, with ultimate-commons * Ports * group * up * Addresses * Typo. * Redis key * Redis key as a parameter * ultimate * parameters * job name * jobs * Cosmetics * cosmetics * cosmetics * jobs * Descriptions

* Introduce ultimate erc-to-erc * Added metamask setup * Corrected configuration parameters

* Started monitor-e2e rewrite * axios * Implemented tests * Monitor start * First deploy * Wait for monitor * Removed redundant files * Tests. * TODO * Links to minitor in constants * Typo. * [PR-into-PR] Monitor E2E rewrite - balance (omni#191) * Test run for more monitor-e2e tests * macos/docker * timeout * Little refactor * Trying to test balances in other types of bridges. * Utils. * test * check all * erc to erc try * Final tests * typo * All jobs * Lint * Roll back docker in docker * WaitUntil * Axios version * New validator checks (omni#192)

* New repo task * Removed bridge_repo and bridge_repo_branch configs * Updated docs * Update apt-get * Fix path * Exclude fix * Removed CODEBASE_BRANCH * Initializing submodules for deployment tests * Synchronizing with ls-tree * Synchronization without temp files

* Moved deployment/molecule to deployment-e2e * Update paths and readmes * Nested molecule * Corrected paths * paths * path * Moved docker up

jeremyjams · 2024-02-05T13:16:36Z

Dockerfile.e2e

 WORKDIR /mono
 COPY package.json .
 COPY oracle-e2e/package.json ./oracle-e2e/
 COPY monitor-e2e/package.json ./monitor-e2e/
-COPY contracts/package.json ./contracts/
+# COPY contracts/package.json ./contracts/


Suggested change

# COPY contracts/package.json ./contracts/

jeremyjams · 2024-02-05T13:23:08Z

oracle-e2e/test/ercToNative.js

+    // Retrieve initial balances
+    const initialTokenBalance = await erc20Token.methods.balanceOf(user.address).call();
+    console.log("Initial ERC20 Token Balance:", initialTokenBalance);
+    500000000000000000000


Suggested change

500000000000000000000

jeremyjams · 2024-02-05T13:42:49Z

oracle-e2e/test/ercToNative.js

-      }
-    })
-  })
+    });


Why not:
assertEquals(newForeignBalance, oldForeignBalance - transferedValue)
assertEquals(newHomeBalance, oldHomeBalance + transferedValue * 10e9)
?

yes I can add that, these asserts were not in the init test

jeremyjams · 2024-02-05T13:51:15Z

oracle/src/events/processSignatureRequests/index.js

@@ -38,7 +38,8 @@ function processSignatureRequestsBuilder(config) {
    rootLogger.debug(`Processing ${signatureRequests.length} SignatureRequest events`)
    const callbacks = signatureRequests
      .map(signatureRequest => async () => {
-        const { recipient, value } = signatureRequest.returnValues
+        const { recipient } = signatureRequest.returnValues
+        let { value } = signatureRequest.returnValues


Why changing it (same comment below)?

It's due to line 48, we may need to update value in case of decimal shift

Ok thanks! (Not sure to see how it was working before though 🤔 )

oracle/src/events/processTransfers/index.js

zguesmi

Well done !

zguesmi · 2024-02-08T19:08:03Z

deployment/group_vars/dai.yml

-BRIDGE_MODE: "ERC_TO_NATIVE"
-HOME_NATIVE_NAME: "xDai"
+ORACLE_BRIDGE_MODE: "ERC_TO_NATIVE"
+UI_NATIVE_TOKEN_DISPLAY_NAME: "xDai"


Do we need to change this in the UI deployer repository ?
From:

REACT_APP_HOME_NATIVE_NAME=vRLC

zguesmi · 2024-02-08T19:12:08Z

monitor/.env.example

-HOME_BRIDGE_ADDRESS=0x63CBf84596d0Dc13fCE1d8FA4470dc208390998a
-FOREIGN_BRIDGE_ADDRESS=0x1e32aFA55854B6c015D284E3ccA9aA5a463A1418
-HOME_DEPLOYMENT_BLOCK=0
+COMMON_HOME_RPC_URL=https://viviani.iex.ec


Do we need to update the deployer repository to use new names?

rzadp and others added 30 commits July 22, 2019 09:37

Remove default syslog server port. (omni#152)

5d22ad1

Oracle using ERC_TYPES from commons (omni#163)

5c92cf5

UI using abis from commons (omni#164)

d3653bc

* Renamed v1 abi names * Home store using v1 from commons * Using ERC20_BYTES32_ABI from commons

Monitor remote logging (omni#162)

c94b68a

* Added remote logging for monitor * Legacy line * Tempaltes

Add cron schedule to monitor deployment playbook (omni#161)

9c82597

* Default cron schedule * Added cron task * Docs * Overwriting log files * Removed deprecated flag * Default monitor_cron_schedule.

chrome.deb

b532c8b

Revert "chrome.deb"

93ebcc0

b532c8b

Explicit and supported chrome version for ui-e2e (omni#172)

984b238

New security audit report for the contracts v2.3.2 (omni#169)

272dc14

* new security audit report for the contracts v2.3.2 * contracts updated to points to latest commit

Extending monitor-e2e with 3 types of bridge (omni#170)

a2e9dae

* Started working on monitor-e2e * Monitor e2e tests extended for 3 types of bridge * Skipp error checking * bash fix * Fixed docker-compose * check first * grep errors * all jobs * Style * Executing instead of sourcing

Extend line width to 120 (omni#174)

40be5a5

* Extend line width to 120 * Lint fixes

Molecule tests for Monitor deployment (omni#176)

f3419cb

* Monitor deployment testing - initial commit. * deployment-monitor job * one job * Additional tests. * server port. * lint * all jobs

Refactor CI config (omni#177)

52239a9

* Update ci config version * try to use orb * command * naming * Common docker executor config * Machine in orb * Common tasks * common caching * nvm * Final test

Fix flaky UI-E2E (omni#178)

2be0e9f

* Change user * jobs * Revert "Change user" 5fa7084 * Trying to use block generator address * jobs * Fixed * 5 jobs * 10 jobs * all jobs * finish * Removed jobs * Add funds for block generator in block genesis

Ultimate E2E for ERC TO NATIVE (omni#182)

76daf5a

* Introducing ultimate erc-to-native, with ultimate-commons * Ports * group * up * Addresses * Typo. * Redis key * Redis key as a parameter * ultimate * parameters * job name * jobs * Cosmetics * cosmetics * cosmetics * jobs * Descriptions

Update contract's submodule to 2.4.0 (omni#183)

2093ff2

Update chrome version (omni#185)

244306f

Ultimate tests for ERC-TO-ERC (omni#186)

6aafce0

* Introduce ultimate erc-to-erc * Added metamask setup * Corrected configuration parameters

Add a note about resetting nonces (omni#189)

b4ec041

Fix docker command (omni#190)

f72ca7d

Simplify Molecule developemnt (omni#193)

c39e81f

Remove deprecated config option (omni#166)

9af253b

Move molecule to deployment-e2e (omni#196)

677bc50

* Moved deployment/molecule to deployment-e2e * Update paths and readmes * Nested molecule * Corrected paths * paths * path * Moved docker up

gfournieriExec requested review from zguesmi and jeremyjams January 22, 2024 10:46

gfournieriExec self-assigned this Jan 22, 2024

gfournieriExec added 6 commits January 25, 2024 09:35

update dockerifle e2e github issue

8b44d6f

update oracle dockerfile to node 16

b125dba

update docker monitor

2e3873d

update linked contracts repo

5a299b6

update e2e to pass

8bad2fa

update dockerfile and compose to match old

74117a0

jeremyjams reviewed Feb 5, 2024

View reviewed changes

gfournieriExec marked this pull request as ready for review February 5, 2024 13:57

gfournieriExec added 4 commits February 6, 2024 09:42

erase number in test script

65fcacc

moove oracle jenkins file to oracle sub folder

6db6a3e

erase arg dot env in dockerfile

0faf0b0

update pvk oracle env name

4a540dc

zguesmi approved these changes Feb 9, 2024

View reviewed changes

gfournieriExec added 14 commits February 9, 2024 13:52

remove foreign FOREIGN_TO_HOME_DECIMAL_SHIFT from process affirmation

e3694f0

erase process env

d4cf927

debug estimateGas

04a44f6

debug homebridge

f2cee83

debug #3

3b96c33

debug estimate gas

6062cd0

show encoded abi after change

2fe3299

add it to process Affirmation

6a68671

update console log

dd53441

remove the use of FOREIGN_TO_HOME_DECIMAL_SHIFT in transfer event

4a21334

testing no FOREIGN_TO_HOME_DECIMAL_SHIFT on signature request

b062582

clean code remove unused env variable

bbc0ae9

debug collected signatures

a4158be

add console log

b1050f4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade 1.0.0-rc0 -> 1.0.0 version #10

Upgrade 1.0.0-rc0 -> 1.0.0 version #10

gfournieriExec commented Jan 22, 2024

jeremyjams Feb 5, 2024

jeremyjams Feb 5, 2024

jeremyjams Feb 5, 2024

gfournieriExec Feb 6, 2024

jeremyjams Feb 5, 2024

gfournieriExec Feb 6, 2024

jeremyjams Feb 6, 2024

zguesmi left a comment

zguesmi Feb 8, 2024

zguesmi Feb 8, 2024

Upgrade 1.0.0-rc0 -> 1.0.0 version #10

Are you sure you want to change the base?

Upgrade 1.0.0-rc0 -> 1.0.0 version #10

Conversation

gfournieriExec commented Jan 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zguesmi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment