Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common gasprice #179

Merged
merged 36 commits into from
Aug 5, 2019
Merged

Common gasprice #179

merged 36 commits into from
Aug 5, 2019

Conversation

rzadp
Copy link
Contributor

@rzadp rzadp commented Aug 2, 2019 •
edited
Loading

  • Progresses Introduce bridge-commons #8
  • Extracted common functions from ui, oracle and monitor to commons
  • Moved some tests from oracle and ui to commons

@rzadp rzadp added the shared shared components label Aug 2, 2019
@rzadp rzadp changed the title [WIP] Common gasprice Common gasprice Aug 2, 2019
@rzadp rzadp marked this pull request as ready for review August 2, 2019 15:21
@rzadp rzadp requested review from patitonar and akolotov and removed request for patitonar August 2, 2019 15:24
akolotov
akolotov approved these changes Aug 5, 2019
View reviewed changes
Copy link
Collaborator

@akolotov akolotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge without @patitonar approval

@akolotov akolotov mentioned this pull request Aug 5, 2019
Closed
@rzadp rzadp merged commit 055a444 into master Aug 5, 2019
@rzadp rzadp deleted the common-gasprice branch August 5, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akolotov akolotov akolotov approved these changes

@patitonar patitonar patitonar approved these changes

Assignees
No one assigned
Labels
shared shared components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rzadp @patitonar @akolotov