New way of deploying repository #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzadp
changed the title
rzadp
changed the title
rzadp
changed the title
akolotov
reviewed
Aug 27, 2019
| shell: git submodule update --init | ||
| args: | ||
| chdir: "{{ bridge_path }}" | ||
| src: ../../../.. |
There was a problem hiding this comment.
As I mentioned in #194 consider to copy just files from git ls-tree -r HEAD --name-only
ArseniiPetrovich
suggested changes
Aug 27, 2019
| file: | ||
| path: "{{ bridge_path }}" | ||
| state: directory | ||
| - name: Synchronize the repository with current files |
There was a problem hiding this comment.
It's better to split tasks with a newline.
Also I would agree with @akolotov on using ls-tree command
There was a problem hiding this comment.
@ArseniiPetrovich Done, please review again.
akolotov
approved these changes
Aug 28, 2019
ArseniiPetrovich
approved these changes
Aug 28, 2019
This was referenced Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Tests do not handle forked Pull Requests #167 by changing the task cloning the repository, to just copy the files
Removed now-obsolete
bridge_repoandbridge_repo_branchconfigsNote that this PR is a forked PR from
rzadp/tokenbridge, demonstrating working testsRelated PR: Molecule tests for deploying repository #194
TODO: Manually test deployment on DigitalOcean