-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests do not handle forked Pull Requests #167
Comments
At the moment I don't have a good idea on how to handle this. @ArseniiPetrovich @phahulin @akolotov Do you have some idea on how to handle it? |
I can think of another way to approach this - change the playbooks. Instead of doing a |
I think it's a good idea to just copy the files 👍 |
correct. but we need to make sure that
|
The first PR #166 to the monorepo from a forked repository revealed that the deployment tests do not handle such kind of PRs.
The reason is that the deployment playbooks use
git pull
, and in order to test the deployment together with changes to codebase on a given branch, we pull "current branch".But the "current branch" does on exist on our monorepo, it only exists on a forked repo - so
git pull
fails.The text was updated successfully, but these errors were encountered: