Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests do not handle forked Pull Requests #167

Closed
rzadp opened this issue Jul 26, 2019 · 4 comments · Fixed by #195
Closed

Tests do not handle forked Pull Requests #167

rzadp opened this issue Jul 26, 2019 · 4 comments · Fixed by #195
Labels
e2e related to end to end testing

Comments

@rzadp
Copy link
Contributor

rzadp commented Jul 26, 2019

The first PR #166 to the monorepo from a forked repository revealed that the deployment tests do not handle such kind of PRs.

The reason is that the deployment playbooks use git pull, and in order to test the deployment together with changes to codebase on a given branch, we pull "current branch".
But the "current branch" does on exist on our monorepo, it only exists on a forked repo - so git pull fails.

@rzadp rzadp added the e2e related to end to end testing label Jul 26, 2019
@rzadp
Copy link
Contributor Author

rzadp commented Jul 26, 2019

At the moment I don't have a good idea on how to handle this.
I guess one way would be to pull "current repo", in addition to "current branch"

@ArseniiPetrovich @phahulin @akolotov Do you have some idea on how to handle it?

@rzadp
Copy link
Contributor Author

rzadp commented Jul 26, 2019

I can think of another way to approach this - change the playbooks.

Instead of doing a git pull task, we would just use a task to copy the files we have locally.
Since locally we have just the files we want to test.
And also it would remove the need to git push first.

@phahulin
Copy link
Contributor

I think it's a good idea to just copy the files 👍

@akolotov
Copy link
Collaborator

correct. but we need to make sure that

  1. all files are added to the index
  2. only added files are copied
    It could prevent cases when the local tests are performed well but failed when the changes are pushed to the remote repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e related to end to end testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants