-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ultimate E2E tests #158
Ultimate E2E tests #158
Conversation
@@ -0,0 +1,3 @@ | |||
--- | |||
- import_playbook: ../../site.yml | |||
- import_playbook: ./overwrite-docker-compose.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The modification of Oracle's docker-compose.yml
file is necessary in order to add ultimate
network - joining the containers with parity containers
.circleci/config.yml
Outdated
- run: 'echo "TODO - Run the e2e tests on top of the infrastructure created by previous step"' | ||
- run: | ||
name: Wait for the Oracle to start | ||
command: 'sleep 120' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did try to have a more smart way to wait - waiting until "Required block confirmations obtained"
record appears in the logs or similar.
I had trouble making that work, with the docker-in-docker situation and all, and eventually gave up - at least for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it possible to get data from RedisDB to get information about observed blocks? By doing this (or even by watching if it changes) we could confirm that the oracle is up and running
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rzadp ⬆️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it most likely is possible, I will try to make it happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done - monitoring redis value of native-erc-collected-signatures:lastProcessedBlock
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment to investigate the ability to check if the oracle is running through getting valued from redisdb
This is done now. |
macos
flag andDOCKER_LOCALHOST
- thanks to combining the containers in anultimate
docker network, it is no longer needed