Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ultimate E2E tests #158

Merged
merged 24 commits into from
Jul 26, 2019
Merged

Ultimate E2E tests #158

merged 24 commits into from
Jul 26, 2019

Conversation

rzadp
Copy link
Contributor

@rzadp rzadp commented Jul 18, 2019

  • Progresses Ultimate E2E tests #121
    • Covers ultimate tests for native-to-erc type of bridge, and oracle-e2e tests
  • Adds docs and diagrams about the ultimate e2e: Ultimate
  • Removes the macos flag and DOCKER_LOCALHOST - thanks to combining the containers in an ultimate docker network, it is no longer needed

@rzadp rzadp added the e2e related to end to end testing label Jul 18, 2019
@@ -0,0 +1,3 @@
---
- import_playbook: ../../site.yml
- import_playbook: ./overwrite-docker-compose.yml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modification of Oracle's docker-compose.yml file is necessary in order to add ultimate network - joining the containers with parity containers

- run: 'echo "TODO - Run the e2e tests on top of the infrastructure created by previous step"'
- run:
name: Wait for the Oracle to start
command: 'sleep 120'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did try to have a more smart way to wait - waiting until "Required block confirmations obtained" record appears in the logs or similar.

I had trouble making that work, with the docker-in-docker situation and all, and eventually gave up - at least for now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it possible to get data from RedisDB to get information about observed blocks? By doing this (or even by watching if it changes) we could confirm that the oracle is up and running

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rzadp ⬆️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it most likely is possible, I will try to make it happen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done - monitoring redis value of native-erc-collected-signatures:lastProcessedBlock.

@rzadp rzadp changed the title [WIP] Ultimate e2e Ultimate E2E tests Jul 18, 2019
@rzadp rzadp marked this pull request as ready for review July 18, 2019 12:49
@rzadp rzadp requested review from akolotov and phahulin July 18, 2019 12:51
Copy link
Collaborator

@akolotov akolotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment to investigate the ability to check if the oracle is running through getting valued from redisdb

@rzadp
Copy link
Contributor Author

rzadp commented Jul 23, 2019

Added a comment to investigate the ability to check if the oracle is running through getting valued from redisdb

This is done now.

@rzadp rzadp merged commit c9d1004 into master Jul 26, 2019
@rzadp rzadp deleted the ultimate-e2e branch July 26, 2019 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e related to end to end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants