-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cron schedule to monitor deployment playbook #161
Conversation
--- | ||
- name: Parse cron schedule | ||
set_fact: | ||
minute: "{{ MONITOR_CRON_SCHEDULE.split(' ')[0] }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work when MONITOR_CRON_SCHEDULE
is not set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If MONITOR_CRON_SCHEDULE
is not set or invalid, task fails.
The playbook continues because ignore_errors: True
.
The Add cron entry
is then skipped because when: not set_fact_result.failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should always install cron for monitor (otherwise it just checks ones), and so add a default for MONITOR_CRON_SCHEDULE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I made the changes in the playbook and the docs, and also renamed MONITOR_CRON_SCHEDULE
to monitor_cron_schedule
to match style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge as soon as @phahulin or @ArseniiPetrovich approve. thanks!
disable-legacy-registry
which is removed from Docker as of v18.03Tested by performing:
MONITOR_CRON_SCHEDULE
not-setMONITOR_CRON_SCHEDULE
setMONITOR_CRON_SCHEDULE
set, then stopped thetokenbridge-monitor
service