-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pydaikin to 2.13.4 #123623
Bump pydaikin to 2.13.4 #123623
Conversation
Hey there @fredrike, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
I suggest to handle that comment before this PR is merged: fredrike/pydaikin#16 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea blocking this for now, because otherwise we'll introduce a problem for users with 1+ device
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Upgrade to 2.13.4 instead.. |
I do have multiple devices indeed, as many users I guess. |
Proposed change
Bump
pydaikin
to2.13.4
to fix Daikin SSL and header regressions in Home Assistant 2024.8.1fredrike/pydaikin@v2.13.2...v2.13.4
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: