-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dakin integration does blocking I/O in the event loop to import modules and ssl certificates #114345
Comments
Hey there @fredrike, mind taking a look at this issue as it has been labeled with an integration ( Code owner commandsCode owners of
(message by CodeOwnersMention) daikin documentation |
@frenck Since this issue is still open I assume the milestone 2024.4.0 you assigned is not correct? |
@tomlut The PyDaikin source code is now on GitHub. You might want to change the links in your issue description and/or create an issue in that repository: https://github.com/fredrike/pydaikin |
There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. |
Still an issue core-2024.7.4 |
The problem
As per private discussion with bdraco about relatively long Daikin integration start up times, he discovered that the Daikin integration does I/O blocking in the event loop:
... it does blocking I/O in the event loop
https://bitbucket.org/mustang51/pydaikin/src/45f5ead619d861727626a7ab0522a0c18f00e0ba/pydaikin/daikin_base.py#lines-59
these imports do blocking I/O in the event loop
creating an ssl context does blocking I/O in the event loop https://bitbucket.org/mustang51/pydaikin/src/45f5ead619d861727626a7ab0522a0c18f00e0ba/pydaikin/daikin_brp072c.py#lines-24 (edited)
What version of Home Assistant Core has the issue?
core-2024.4.0b0
What was the last working version of Home Assistant Core?
No response
What type of installation are you running?
Home Assistant OS
Integration causing the issue
Daikin
Link to integration documentation on our website
https://www.home-assistant.io/integrations/daikin/
Diagnostics information
No response
Example YAML snippet
No response
Anything in the logs that might be useful for us?
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: