Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dakin integration does blocking I/O in the event loop to import modules and ssl certificates #114345

Closed
tomlut opened this issue Mar 27, 2024 · 6 comments · Fixed by #123623
Closed

Comments

@tomlut
Copy link

tomlut commented Mar 27, 2024

The problem

As per private discussion with bdraco about relatively long Daikin integration start up times, he discovered that the Daikin integration does I/O blocking in the event loop:

... it does blocking I/O in the event loop

https://bitbucket.org/mustang51/pydaikin/src/45f5ead619d861727626a7ab0522a0c18f00e0ba/pydaikin/daikin_base.py#lines-59

these imports do blocking I/O in the event loop

creating an ssl context does blocking I/O in the event loop https://bitbucket.org/mustang51/pydaikin/src/45f5ead619d861727626a7ab0522a0c18f00e0ba/pydaikin/daikin_brp072c.py#lines-24 (edited)

What version of Home Assistant Core has the issue?

core-2024.4.0b0

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Daikin

Link to integration documentation on our website

https://www.home-assistant.io/integrations/daikin/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@home-assistant
Copy link

Hey there @fredrike, mind taking a look at this issue as it has been labeled with an integration (daikin) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of daikin can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign daikin Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


daikin documentation
daikin source
(message by IssueLinks)

@cremor
Copy link

cremor commented May 4, 2024

@frenck Since this issue is still open I assume the milestone 2024.4.0 you assigned is not correct?

@cremor
Copy link

cremor commented May 4, 2024

@tomlut The PyDaikin source code is now on GitHub. You might want to change the links in your issue description and/or create an issue in that repository: https://github.com/fredrike/pydaikin

@tomlut
Copy link
Author

tomlut commented May 6, 2024

fredrike/pydaikin#3

@kingy444 kingy444 mentioned this issue Jun 3, 2024
20 tasks
@issue-triage-workflows
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@tomlut
Copy link
Author

tomlut commented Aug 4, 2024

Still an issue core-2024.7.4

@kingy444 kingy444 mentioned this issue Aug 11, 2024
19 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants