Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pydaikin to 2.13.2 #123519

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Conversation

mattyway
Copy link
Contributor

@mattyway mattyway commented Aug 10, 2024

Proposed change

Bump pydaikin to 2.13.2 to fix Daikin BRP072C devices not working in Home Assistant 2024.8

fredrike/pydaikin@v2.13.1...v2.13.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mattyway

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft August 10, 2024 09:43
@home-assistant
Copy link

Hey there @fredrike, mind taking a look at this pull request as it has been labeled with an integration (daikin) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of daikin can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign daikin Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@mattyway mattyway force-pushed the bump-pydaikin-2.13.2 branch from 3cd63c2 to 8ddd5ef Compare August 10, 2024 09:45
Copy link
Contributor

@liudger liudger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joostlek joostlek added this to the 2024.8.1 milestone Aug 10, 2024
@joostlek joostlek merged commit 5f03589 into home-assistant:dev Aug 10, 2024
36 checks passed
frenck pushed a commit that referenced this pull request Aug 10, 2024
@frenck frenck mentioned this pull request Aug 10, 2024
@albertoarmida
Copy link

After these merge my Daikin integration does not work and I receive these error message

Registratore: pydaikin.daikin_base
Fonte: components/daikin/init.py:88
Prima occorrenza: 20:43:37 (4 occorrenze)
Ultima registrazione: 20:43:37

Exception in TaskGroup: 'DaikinBRP069' object has no attribute 'headers'

@Jonssii
Copy link

Jonssii commented Aug 10, 2024

After these merge my Daikin integration does not work and I receive these error message

Registratore: pydaikin.daikin_base Fonte: components/daikin/init.py:88 Prima occorrenza: 20:43:37 (4 occorrenze) Ultima registrazione: 20:43:37

Exception in TaskGroup: 'DaikinBRP069' object has no attribute 'headers'

Same here, I'm getting the same error message and the Daikin integration stopped working.

@rogervdh
Copy link

rogervdh commented Aug 10, 2024

After these merge my Daikin integration does not work and I receive these error message

Registratore: pydaikin.daikin_base Fonte: components/daikin/init.py:88 Prima occorrenza: 20:43:37 (4 occorrenze) Ultima registrazione: 20:43:37

Exception in TaskGroup: 'DaikinBRP069' object has no attribute 'headers'

I have the same issue and error message. I'm using a Daikin BRP069B4x unit.

@svheel
Copy link

svheel commented Aug 10, 2024

Same here on two BRP069B4x units. Rolled back to 2024.8.0 and it works again, so probably has something to do with this update.

@RonFac
Copy link

RonFac commented Aug 11, 2024

My SkyFi unit BRP15A61 has not worked with 2024.8.0 or 2024.8.1
2024-08-11 08:43:58.734 ERROR (MainThread) [pydaikin.daikin_base] Exception in TaskGroup: 'DaikinSkyFi' object has no attribute 'headers'
2024-08-11 08:43:58.737 ERROR (MainThread) [pydaikin.daikin_base] Exception in TaskGroup: 'DaikinSkyFi' object has no attribute 'headers'
2024-08-11 08:43:58.737 ERROR (MainThread) [homeassistant.components.daikin] Unexpected error creating device 192.168.1.137

@mgischer
Copy link

My BRP069 units no longer work as of 2024.8.1. 2024.8.0 is fine. I see the following errors get logged:
024-08-10 16:32:47.352 ERROR (MainThread) [pydaikin.daikin_base] Exception in TaskGroup: 'DaikinBRP069' object has no attribute 'headers'
2024-08-10 16:32:47.354 ERROR (MainThread) [homeassistant.components.daikin] Unexpected error creating device 172.16.8.8

@marcomsousa
Copy link

Please revert back!
My BRP069B4x don't work.

@jurgenweber
Copy link

Yeah, I just upgraded to 2024.8.1 and now my daikin doesn't join

2024-08-11 16:20:26.283 ERROR (MainThread) [pydaikin.daikin_base] Exception in TaskGroup: 'DaikinBRP069' object has no attribute 'headers'
2024-08-11 16:20:26.293 ERROR (MainThread) [homeassistant.components.daikin] Unexpected error creating device 192.168.1.125

@ALERTua
Copy link
Contributor

ALERTua commented Aug 11, 2024

This PR broke my Daikin Air Conditioners integration. Reverting to 2024.8.0 ([email protected]) fixed them.

@joostlek
Copy link
Member

Okay, can we move this to a separate issue instead of using this PR?

@StreneSaco
Copy link

Broke my Daikin integration too

@tofuSCHNITZEL
Copy link
Contributor

Broke my Daikin integration too

the issue is known and worked on.
#123623
fredrike/pydaikin#16 (comment)

@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with BRP072C42 on HA 2024.08.0 Update Daikin suddenly failing on one endpoint with ssl context error