-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pydaikin to 2.13.2 #123519
Bump pydaikin to 2.13.2 #123519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @fredrike, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
3cd63c2
to
8ddd5ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
After these merge my Daikin integration does not work and I receive these error message Registratore: pydaikin.daikin_base Exception in TaskGroup: 'DaikinBRP069' object has no attribute 'headers' |
Same here, I'm getting the same error message and the Daikin integration stopped working. |
I have the same issue and error message. I'm using a Daikin BRP069B4x unit. |
Same here on two BRP069B4x units. Rolled back to 2024.8.0 and it works again, so probably has something to do with this update. |
My SkyFi unit BRP15A61 has not worked with 2024.8.0 or 2024.8.1 |
My BRP069 units no longer work as of 2024.8.1. 2024.8.0 is fine. I see the following errors get logged: |
Please revert back! |
Yeah, I just upgraded to 2024.8.1 and now my daikin doesn't join
|
This PR broke my Daikin Air Conditioners integration. Reverting to 2024.8.0 ([email protected]) fixed them. |
Okay, can we move this to a separate issue instead of using this PR? |
Broke my Daikin integration too |
the issue is known and worked on. |
Proposed change
Bump
pydaikin
to2.13.2
to fix Daikin BRP072C devices not working in Home Assistant 2024.8fredrike/pydaikin@v2.13.1...v2.13.2
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: