-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to instance members #17
Conversation
Have a failure in pylint due to https://pylint.readthedocs.io/en/latest/user_guide/messages/refactor/too-many-instance-attributes.html @fredrike how did you want to deal with that ? |
SSL context doesn't have to be in the constructor as that is not a mutable object like a dict or a list (iirc) At this point just ignore pylint I guess. It would require a refactor to fix those and I'd rather get this in as quick as possible |
Thanks for picking this up btw, I was scared .2 would be another hellish release for a lot of people because of this |
@fredrike should be good to merge now |
Do we need this in HA ASAP too? Can't one of you add yourself as contributors in HA and close the duplicate issues there.. |
I am member, I can do that. I've been trying to do so over the last few days. Hell, I even remember the issue number 😂 |
But yes, we want this, because this will probably fix the issues |
Yes, see home-assistant/core#123623 which is blocked to update to a version with this fix. |
I've pushed a new version to pypi. |
In response to #16 (comment) can we please move the definition to an instance member instead of a class member