Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to instance members #17

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Move to instance members #17

merged 2 commits into from
Aug 13, 2024

Conversation

kingy444
Copy link
Collaborator

In response to #16 (comment) can we please move the definition to an instance member instead of a class member

@kingy444
Copy link
Collaborator Author

Have a failure in pylint due to https://pylint.readthedocs.io/en/latest/user_guide/messages/refactor/too-many-instance-attributes.html

@fredrike how did you want to deal with that ?

@joostlek
Copy link

SSL context doesn't have to be in the constructor as that is not a mutable object like a dict or a list (iirc)

At this point just ignore pylint I guess. It would require a refactor to fix those and I'd rather get this in as quick as possible

@joostlek
Copy link

Thanks for picking this up btw, I was scared .2 would be another hellish release for a lot of people because of this

@kingy444
Copy link
Collaborator Author

@fredrike should be good to merge now

@fredrike fredrike merged commit 89e186b into fredrike:master Aug 13, 2024
3 checks passed
@fredrike
Copy link
Owner

Do we need this in HA ASAP too?

Can't one of you add yourself as contributors in HA and close the duplicate issues there..

@joostlek
Copy link

I am member, I can do that. I've been trying to do so over the last few days. Hell, I even remember the issue number 😂

@joostlek
Copy link

But yes, we want this, because this will probably fix the issues

@cremor
Copy link
Collaborator

cremor commented Aug 13, 2024

Do we need this in HA ASAP too?

Yes, see home-assistant/core#123623 which is blocked to update to a version with this fix.

@fredrike
Copy link
Owner

I've pushed a new version to pypi.

@fredrike fredrike added the Base Base class label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Base Base class
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants