Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag Pages in DCAR for Dotcom #8314

Open
14 of 17 tasks
OllysCoding opened this issue Jul 20, 2023 · 2 comments
Open
14 of 17 tasks

Tag Pages in DCAR for Dotcom #8314

OllysCoding opened this issue Jul 20, 2023 · 2 comments

Comments

@OllysCoding
Copy link
Contributor

OllysCoding commented Jul 20, 2023

Coming back to this work, don't miss this comment
!!!

What are tag fronts?

Fronts can generally be separated into two categories:

  1. Pressed Fronts - These fronts, like https://www.theguardian.com/uk are ones that are created in the fronts tool by digital editors, and are then 'pressed' into a JSON form by facia-press in Frontend.
  2. Tag Pages - These pages, like https://www.theguardian.com/tone/minutebyminute are similar to fronts but created automatically, and come with a tag created in tag manager. They display a date ordered set of content associated with a given tag.

DCR's pressed front rollout is (almost) complete - but tag fronts need their own data model & features, which need to be built & supported.

What's left to do?

Pre 1%

Preview Give feedback
  1. Tag Pages Tag Pages Go-live 1%
    OllysCoding
  2. Bugs from the Fronts migration Tag Pages
    OllysCoding
  3. Tag Pages Tag Pages Go-live 1%
    OllysCoding
  4. Tag Pages Tag Pages Go-live 1%
    OllysCoding
  5. Tag Pages Tag Pages Go-live 1%
  6. Tag Pages Tag Pages Go-live 1%
    alinaboghiu

Post 1%

Preview Give feedback
  1. Team Candidate: Fronts and Curation
  2. Team Candidate: Fronts and Curation
  3. Pick me up Tag Pages
    DanielCliftonGuardian

Subjects / Contributors

Preview Give feedback
  1. Team Candidate: Fronts and Curation

Bugs found during 1% test

Preview Give feedback
  1. Tag Pages
    abeddow91
  2. Pick me up Tag Pages
    abeddow91
  3. Pick me up Tag Pages
    DanielCliftonGuardian
  4. Pick me up Tag Pages
    abeddow91

Bugs found during 20% test

Preview Give feedback
  1. Tag Pages
    ioannakok
@OllysCoding
Copy link
Contributor Author

OllysCoding commented Nov 15, 2023

Revisiting Tag Fronts? Here's what you need to know

What are they?
Tag fronts are automatically generated fronts that exist alongside a tag created in tag manager. They are paginated pages which display all the content published to a tag in date order.

Stories on tag fronts are grouped into containers much like on pressed fronts, however since there's no curation, containers are date based, a container will either show all the stories for a given day, or a given month, depending on the frequency content is being published to that tag.

The standard URL for a tag front is www.theguardian.com/<tag ID>. Tags IDs generally contain a forward slash /, e.g tone/minutebyminute. When both sides of the tag is the same, e.g politics/politics, the url would only contain the one part, e.g www.theguardian.com/politics.

Tag fronts can be overwritten by pressed fronts, e.g in the case of https://www.theguardian.com/tone/recipes. In this case, the tag front can be found at www.theguardian.com/<tag ID>/all, e.g https://www.theguardian.com/tone/recipes/all.

There are a few other variants of tag fronts as well:

There are a few others that will be detailed later.

What has been done so far?

PRs: guardian/frontend#26149 #7752 guardian/frontend#26233 #8056 #9336 #9340 #9344 #9405 #9450

In frontend we have defined a datamodel for tag fronts, and set up the ability for frontend to send requests to DCR with that model, and created a 'TagFrontPicker' that decides what rendering tier to render tag fronts on.

In DCR we've created a tag front layout, all the accomanying types, models & data transformation as well as pagination & ad support.

What does this result in?

We support the following URLs

  • www.theguardian.com/<tag ID>
  • www.theguardian.com/<tag ID>/all

We don't support the following URLs

  • www.theguardian.com/<tag ID>/<year>/<month>/<day>/all
  • www.theguardian.com/<tag ID 1>+<tag ID 2>
  • www.theguardian.com/theguardian

What to do first

The best first step is to work toward launching a 1% test. This will allow you to test that everything that's been implemented up and till now is working as expected, before investing further effort in the other tag front URLs.

Before launching a 1% test, you'll need to identify which tag fronts should be excluded. Some tag fronts have extra data injected by Frontend, which won't yet be supported by DCR. Some known examples of this are the accessibility help page: https://www.theguardian.com/help/accessibility-help and football teams: https://www.theguardian.com/football/paris-fc.

Once this is complete, you should be good-to-go with the usual 1% DCR migration approach (set up 0% test in order to check everything, talk to d&i, notify Central prod & user help, launch)

What to do second

Once the 1% test launch is complete, you can start to migrate the other 'types' of tag pages, for each of these you'll generally want to follow a formula along the lines of:

  • Investigate differences: What makes this page different that normal tag fronts, e.g different pagination, different data, etc.
  • Determine how much can be re-used, e.g the data model, DCR endpoint, DCR layout & components
  • Build frontend side, hook up the json datamodel or adjust as required
  • Build DCR side, make necessary adjustments to support any different data, or visual changes.

Subjects / Contributors

This seems like a good time to migrate the subjects & contributors pages as well. They can be found here:

https://www.theguardian.com/index/subjects
https://www.theguardian.com/index/contributors

@georgeblahblah georgeblahblah moved this from Planned to Backlog in WebX Team Nov 21, 2023
@cemms1 cemms1 changed the title [EPIC] Tag Fronts [EPIC] Tag Pages Jan 19, 2024
@cemms1
Copy link
Contributor

cemms1 commented Jan 19, 2024

Edited title and description to reflect chosen terminology of "tag pages" rather than referring to them as "fronts"

@JamieB-gu JamieB-gu removed the Epic label Oct 16, 2024
@JamieB-gu JamieB-gu changed the title [EPIC] Tag Pages Tag Pages in DCAR for Dotcom Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

5 participants