Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up spacing on pagination #8317

Closed
Tracked by #8314
OllysCoding opened this issue Jul 20, 2023 · 1 comment
Closed
Tracked by #8314

Tidy up spacing on pagination #8317

OllysCoding opened this issue Jul 20, 2023 · 1 comment
Assignees
@OllysCoding
Labels
Bugs from the Fronts migration Tag Pages
Milestone
Tag Pages

Comments

@OllysCoding
Copy link
Contributor

OllysCoding commented Jul 20, 2023 •
edited
Loading

The spacing (padding/margins) on tag fronts pagination is a bit rushed, and probably needs 'evened out' and refactored to better match frontend (or to just look better overall)

Example Frontend: https://www.theguardian.com/tone/minutebyminute
Example DCR: https://www.theguardian.com/tone/minutebyminute?dcr

DCR Frontend
dcr frontend
dcr1 frontend1
@OllysCoding OllysCoding mentioned this issue Jul 20, 2023
Open
@OllysCoding OllysCoding added this to the Tag fronts Pre 1% milestone Jul 20, 2023
@rhiannareechaye rhiannareechaye moved this from Triage to Backlog in WebX fronts migration Jul 20, 2023
@rhiannareechaye rhiannareechaye moved this from Triage to Backlog in Deprecated: WebX Health and Rota Jul 27, 2023
@github-project-automation github-project-automation bot moved this to Triage in WebX Team Oct 26, 2023
@OllysCoding OllysCoding modified the milestones: Health, Tag Fronts Oct 26, 2023
@OllysCoding OllysCoding moved this from Triage to Planned in WebX Team Oct 26, 2023
@OllysCoding OllysCoding moved this from Planned to In progress in WebX Team Oct 30, 2023
@OllysCoding OllysCoding moved this from In progress to Planned in WebX Team Oct 30, 2023
@OllysCoding OllysCoding moved this from Planned to In progress in WebX Team Nov 3, 2023
@OllysCoding OllysCoding self-assigned this Nov 3, 2023
@OllysCoding OllysCoding mentioned this issue Nov 6, 2023
Merged
@OllysCoding
Copy link
Contributor Author

Closed in #9405

@github-project-automation github-project-automation bot moved this from In progress to Done in WebX Team Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OllysCoding OllysCoding

Labels
Bugs from the Fronts migration Tag Pages
Projects
WebX Team
Archived in project
Deprecated: WebX Health and Rota
Status: Backlog
Milestone
Tag Pages
Development

No branches or pull requests
3 participants
@alinaboghiu @OllysCoding @rhiannareechaye