Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tag Pages] Pagination missing on /all URLs #10556

Closed
Tracked by #8314
cemms1 opened this issue Feb 12, 2024 · 3 comments · Fixed by #10975 or guardian/frontend#26991
Closed
Tracked by #8314

[Tag Pages] Pagination missing on /all URLs #10556

cemms1 opened this issue Feb 12, 2024 · 3 comments · Fixed by #10975 or guardian/frontend#26991
Assignees
Milestone

Comments

@cemms1
Copy link
Contributor

cemms1 commented Feb 12, 2024

Pagination missing on /all tag pages

Example URL: https://www.theguardian.com/sport/all

Should look like the following screenshot:
image

@cemms1 cemms1 changed the title Pagination missing on /all URLs [Tag Pages] Pagination missing on /all URLs Feb 12, 2024
@cemms1 cemms1 added this to WebX Team Feb 12, 2024
@github-project-automation github-project-automation bot moved this to Triage in WebX Team Feb 12, 2024
@cemms1 cemms1 added this to the Tag Pages milestone Feb 12, 2024
@cemms1 cemms1 moved this from Triage to Next Sprint in WebX Team Feb 12, 2024
@cemms1 cemms1 added the Pick me up small effort, self contained issues to do when you feel like a pick me up, waiting to be unblocked… label Feb 12, 2024
@cemms1 cemms1 moved this from Next Sprint to This Sprint in WebX Team Feb 13, 2024
@ioannakok ioannakok self-assigned this Feb 13, 2024
@ioannakok ioannakok moved this from This Sprint to In Progress in WebX Team Feb 13, 2024
@alinaboghiu alinaboghiu moved this from In Progress to This Sprint in WebX Team Feb 20, 2024
@JamieB-gu JamieB-gu moved this from This Sprint to Next Sprint in WebX Team Feb 28, 2024
@ioannakok ioannakok moved this from Next Sprint to Backlog in WebX Team Mar 13, 2024
@alinaboghiu
Copy link
Member

This will be because we never implemented /all: #8321

@ioannakok
Copy link
Contributor

Specifically, it's the /all.json route that's missing. Once we add it, these will stop returning 404: https://www.theguardian.com/sport/all.json?dcr

And then we have to add the pagination data for /all pages to the DCR model. Atm we're only sending pagination data for regular tag pages (e.g. https://www.theguardian.com/politics/michaelgove.json?dcr). In regular tag pages pagination comes from Tag

Screenshot 2024-03-14 at 15 54 09

In /all pages pagination comes from Metadata

Screenshot 2024-03-14 at 15 54 09

@abeddow91
Copy link
Contributor

### Tasks
- [ ] Add all.json route to Frontend 
- [ ] Add all.json route to Platform router
- [ ]  pass pagination from frontend to DCR
- [ ] 

@abeddow91 abeddow91 self-assigned this Mar 20, 2024
@abeddow91 abeddow91 moved this from Backlog to In Progress in WebX Team Mar 20, 2024
@abeddow91 abeddow91 moved this from In Progress to Review in WebX Team Mar 21, 2024
@alinaboghiu alinaboghiu removed the Pick me up small effort, self contained issues to do when you feel like a pick me up, waiting to be unblocked… label Mar 21, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in WebX Team Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
4 participants