Add all json route for tag pages #26991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -91,7 +91,7 @@ GET /$path<.+>/latest/email.emailtxt | |||
| GET /$path<.+>/$year<\d\d\d\d>/$month<\w\w\w>/$day<\d\d>/all controllers.AllIndexController.allOn(path, day, month, year) | |||
| GET /$path<.+>/$year<\d\d\d\d>/$month<\w\w\w>/$day<\d\d>/altdate controllers.AllIndexController.altDate(path, day, month, year) | |||
| GET /$path<.+>/all controllers.AllIndexController.all(path) | |||
|
|
|||
| GET /$path<.+>/all.json controllers.AllIndexController.renderJson(path) | |||
There was a problem hiding this comment.
Should this go above GET /$path<.+>/all controllers.AllIndexController.all(path) otherwise it will always be missed ?
There was a problem hiding this comment.
Is this because conf/routes only checks prefixes?
cemms1
approved these changes
Mar 21, 2024
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @abeddow91 10 minutes and 55 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @abeddow91 12 minutes ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a "/all.json" tag page route. This allows DCR to support "/all" tag pages (eg www.guardian.com/sport/all).
As well as this, it adds additional logic to relocate pagination data on the DCR model, rather than nesting it within tags.
This is because, whilst regular tag pages have pagination data in tags, "/all" tag pages have this data in metadata. By relocating pagination on the model, we make it easier for DCR to find and use this data.
This PR can be tested E2E by deploying to CODE along with guardian/dotcom-rendering#10975 and https://github.com/guardian/platform/pull/1584
Screenshots
Checklist