Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tag Pages] Pillar selection missing #10559

Closed
Tracked by #8314
cemms1 opened this issue Feb 12, 2024 · 0 comments · Fixed by #10588
Closed
Tracked by #8314

[Tag Pages] Pillar selection missing #10559

cemms1 opened this issue Feb 12, 2024 · 0 comments · Fixed by #10588
Assignees
@abeddow91
Labels
Pick me up small effort, self contained issues to do when you feel like a pick me up, waiting to be unblocked… Tag Pages
Milestone
Tag Pages

Comments

@cemms1
Copy link
Contributor

cemms1 commented Feb 12, 2024 •
edited
Loading

The relevant pillar highlighting is missing from tag pages on DCR.

Example URL: https://www.theguardian.com/sport/blog

Expected behaviour: Sport pillar is highlighted on the top and bottom navigation

DCR:
Screenshot 2024-02-12 at 15 23 12

Frontend:
Screenshot 2024-02-12 at 15 23 26
@cemms1 cemms1 mentioned this issue Feb 12, 2024
Open
@cemms1 cemms1 added this to the Tag Pages milestone Feb 12, 2024
@cemms1 cemms1 added the Pick me up small effort, self contained issues to do when you feel like a pick me up, waiting to be unblocked… label Feb 12, 2024
@abeddow91 abeddow91 self-assigned this Feb 14, 2024
@abeddow91 abeddow91 linked a pull request Feb 15, 2024 that will close this issue
Highlight selected nav with pillar colour on tag pages #10588
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abeddow91 abeddow91

Labels
Pick me up small effort, self contained issues to do when you feel like a pick me up, waiting to be unblocked… Tag Pages
Projects
None yet
Milestone
Tag Pages
Development

Successfully merging a pull request may close this issue.

Highlight selected nav with pillar colour on tag pages guardian/dotcom-rendering
2 participants
@abeddow91 @cemms1