Tag pages in DCR #26149
Merged
Tag pages in DCR #26149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OllysCoding
changed the title
alinaboghiu
reviewed
Jun 1, 2023
alinaboghiu
reviewed
Jun 1, 2023
alinaboghiu
reviewed
Jun 1, 2023
Co-Authored-By: Alina Boghiu <[email protected]>
ioannakok
reviewed
Jun 5, 2023
| "participatingInTest" -> participatingInTest.toString, | ||
| // "testPercentage" -> DCRTagFronts.participationGroup.percentage, | ||
| "dcrCouldRender" -> dcrCouldRender.toString, | ||
| "isFront" -> "true", |
There was a problem hiding this comment.
Should this be renamed to sth like isTagFront so that these pages don't interfere with our current Grafana dashboards / queries?
ioannakok
approved these changes
Jun 5, 2023
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @OllysCoding 18 minutes and 42 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @OllysCoding 19 minutes and 48 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to support tag fronts in DCR (e.g https://www.theguardian.com/tone/minutebyminute).
DCR PR: guardian/dotcom-rendering#7752
Model
This PR creates
DotcomTagFrontsRenderingModelwhich includes the information required for DCR to render a tag front. Helpfully, we're able to use thePressedContentmodel for cards on tag fronts - enabling us to avoid having to build a new card model in DCR.Picker
This PR creates a basic
TagFrontPickerwhich can take a page and decide whether DCR will be able to render it or not - as we don't currently fully support any pages, this will always return false unless?dcris set to true.Logging
This PR moves
DotcomFrontsLoggerinto common, and expands it to support logging for both pressed & tag fronts.Tag endpoints
This PR adds support for
?dcrand.json?dcrto tag front endpoints