Gallery picker #26188
Merged
Gallery picker #26188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioannakok
approved these changes
Jun 8, 2023
|
Seen on FRONTS-PROD, ADMIN-PROD (merged by @alinaboghiu 18 minutes and 59 seconds ago)
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Introduces the ?dcr flag and picker for gallery content, as well as logging that will allow us to track what is rendered in DCR and what in Frontend.
All logic is defaulting to rendering in frontend for now, until we implement this article type in DCR.
This code is by now a very standard approach, following the Article, Fronts, TagPages, Interactives and ImageContent pickers.
Why?
This logic is required to allow us to start building Galleries in DCR. It also allows us to create dashboards to track the progress of the DCR migration.
Tested