Crossword picker and JSON route #26843
Conversation
| )(implicit request: RequestHeader): Future[Result] = { | ||
| val dataModel = DotcomRenderingDataModel.forCrossword(crosswordPage, request, pageType) | ||
| val json = DotcomRenderingDataModel.toJson(dataModel) | ||
| post(ws, json, Configuration.rendering.articleBaseURL + "/Article", CacheTime.Facia) |
There was a problem hiding this comment.
Non blocking comment for this PR: When you pick up the work to implement crosswords in DCR we will need to re-think this endpoint and the base url.
The WebX team is currently under the process of spinning up multiple AWS stacks to split the traffic. Atm we have one stack for articles and one for the rest of the content rendered by DCR (fronts & interactives):
graph LR
Request-->Fastly
Fastly-->Router
Router-->FEArticleLB
Router-->FEFaciaLB
Router-->FEApplicationsLB
subgraph Frontend
FEArticleLB-->FEArticleApp
FEFaciaLB-->FEFaciaApp
FEApplicationsLB-->FEApplicationsApp
end
FEArticleApp--/Article-->DcrArticleLB-->DcrArticleApp
FEFaciaApp--/Front-->DcrRenderingLB-->DcrRenderingApp
FEApplicationsApp--/Interactives-->DcrRenderingLB-->DcrRenderingApp
Which stack handles the traffic is decided by the base url, e.g.
Configuration.rendering.articleBaseURL --> Article app
Configuration.rendering.baseURL --> Rendering app
Crosswords are in applications app in frontend, so it looks like traffic for those will be sent to the same app as interactives.
So your endpoint will be sth like:
- base url --> The correct base url at the time
- endpoint --> You will need to add a
/Crosswordendpoint in DCR
That's all for the future, just wanted to give a heads up - this PR looks good to me!
There was a problem hiding this comment.
That's incredibly helpful info, thank you!
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @andrew-nowak 10 minutes and 49 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @andrew-nowak 12 minutes and 5 seconds ago)
|
What does this change?
Adds in a new JSON route for crossword content to unblock potential local development in DCR, and a CrosswordPicker object to enable ?dcr flag and routing for crossword pages. Primarily following the approach of #26188
Suggest reviewing with ignore-whitespace enabled, to avoid majority of uninteresting changes.
Screenshots
n/a - just JSON
Checklist