DCR flag and picker for Image Content #26169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshCorr
reviewed
May 31, 2023
| description = "Use DCR for image content", | ||
| owners = Seq(Owner.withGithub("@guardian/dotcom-platform")), | ||
| sellByDate = LocalDate.of(2024, 1, 1), | ||
| participationGroup = Perc50, |
There was a problem hiding this comment.
Don't think this should be 50% 😄
There was a problem hiding this comment.
ha! I will change to 0
AshCorr
approved these changes
May 31, 2023
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-FRONTS-PROD
and removed
Pending-on-FRONTS-PROD
labels
|
Seen on FRONTS-PROD (merged by @alinaboghiu 17 minutes and 53 seconds ago)
|
|
Seen on ADMIN-PROD (merged by @alinaboghiu 18 minutes and 1 second ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Allows to force rendering Image Content with DCR by adding the ?dcr flag and a picker file that decides whether image content should be rendered using DCR. We've done the same for Articles and Fronts before so this is a pretty standard approach by now.
This affects content tagged with
type/cartoon,type/picture,type/graphicDoes this change need to be reproduced in dotcom-rendering ?
Tested