This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
Merge in gapic_config_v2 #2721
Merged
Merge in gapic_config_v2 #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as config.proto but different name and different package.
…or into gapic_config_v2
When creating a ResourceNameOneofConfig from protofile annotations, use the already-created collections of SingleResourceNameConfigs and FixedResourceNameConfigs derived from the protofile annotations; this allows for GAPIC config language-specific overrides for resource names.
* Fix missing default retries * Revert python and ruby baselines * Manual update of py and ruby baselines * Remove unneeded diag tracking
* Fix null pointer exception when Api model is null * Correctly handle annotations plus v2 config case for interfaces
…or into gapic_config_v2
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #2721 +/- ##
============================================
+ Coverage 86.95% 87.03% +0.07%
- Complexity 5622 5644 +22
============================================
Files 468 469 +1
Lines 22446 22492 +46
Branches 2433 2432 -1
============================================
+ Hits 19519 19576 +57
+ Misses 2079 2074 -5
+ Partials 848 842 -6
Continue to review full report at Codecov.
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #2721 +/- ##
============================================
+ Coverage 86.95% 87.03% +0.07%
- Complexity 5622 5644 +22
============================================
Files 468 469 +1
Lines 22446 22492 +46
Branches 2433 2432 -1
============================================
+ Hits 19519 19576 +57
+ Misses 2079 2074 -5
+ Partials 848 842 -6
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2721 +/- ##
============================================
+ Coverage 86.95% 87.03% +0.07%
- Complexity 5622 5644 +22
============================================
Files 468 469 +1
Lines 22446 22492 +46
Branches 2433 2432 -1
============================================
+ Hits 19519 19576 +57
+ Misses 2079 2074 -5
+ Partials 848 842 -6
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2721 +/- ##
============================================
+ Coverage 86.96% 87.04% +0.07%
- Complexity 5645 5667 +22
============================================
Files 469 470 +1
Lines 22532 22578 +46
Branches 2437 2436 -1
============================================
+ Hits 19595 19652 +57
+ Misses 2085 2080 -5
+ Partials 852 846 -6
Continue to review full report at Codecov.
|
|
PTAL |
michaelbausor
approved these changes
Apr 22, 2019
busunkim96
pushed a commit
to busunkim96/gapic-generator
that referenced
this pull request
Nov 7, 2019
* Add Gapic config v2 (googleapis#2665) * Whittling down config_v2 (googleapis#2666) * Add ConfigV2 Validator (googleapis#2672) * AutoValue LongRunningConfig; always use gapic config's polling settings (googleapis#2698) * ResourceNameOneofConfig fixes (googleapis#2704) * Start parsing GAPIC config v2 (googleapis#2703) * Bring back timeout millis in GAPIC config v2 (googleapis#2708) * Resource names across different protofiles (googleapis#2711) * Fix missing default retries (googleapis#2718) * Bug fixes for gapic config v2 parsing (googleapis#2717)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes have all been reviewed when PRs were opened against the gapic_config_v2 branch.
Tested these changes by generating the Pubsub clients for all languages and diffing the result against the most recent artman docker image's generation of Pubsub clients. The changes are due only to other PRs, such as #2716, and the lag in protobuf version.