Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Start parsing GAPIC config v2 #2703

Merged
merged 11 commits into from
Apr 9, 2019

Conversation

andreamlin
Copy link
Contributor

@andreamlin andreamlin commented Apr 8, 2019

Toggle on parsing of a GAPIC config v2.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 8, 2019
@andreamlin andreamlin changed the base branch from master to gapic_config_v2 April 8, 2019 23:20
@andreamlin andreamlin requested a review from michaelbausor April 8, 2019 23:21
@andreamlin
Copy link
Contributor Author

PTAL

@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #2703 into gapic_config_v2 will increase coverage by <.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##             gapic_config_v2    #2703      +/-   ##
=====================================================
+ Coverage              86.82%   86.82%   +<.01%     
- Complexity              5602     5606       +4     
=====================================================
  Files                    467      467              
  Lines                  22415    22422       +7     
  Branches                2430     2432       +2     
=====================================================
+ Hits                   19462    19469       +7     
  Misses                  2092     2092              
  Partials                 861      861
Impacted Files Coverage Δ Complexity Δ
...oogle/api/codegen/util/ConfigVersionValidator.java 91.3% <100%> (+7.09%) 9 <7> (+4) ⬆️
.../google/api/codegen/config/GapicProductConfig.java 79.04% <80%> (-0.08%) 92 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff5417c...dd2f082. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #2703 into gapic_config_v2 will increase coverage by <.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##             gapic_config_v2    #2703      +/-   ##
=====================================================
+ Coverage              86.82%   86.83%   +<.01%     
- Complexity              5602     5607       +5     
=====================================================
  Files                    467      467              
  Lines                  22415    22422       +7     
  Branches                2430     2432       +2     
=====================================================
+ Hits                   19462    19470       +8     
  Misses                  2092     2092              
+ Partials                 861      860       -1
Impacted Files Coverage Δ Complexity Δ
...oogle/api/codegen/util/ConfigVersionValidator.java 91.3% <100%> (+7.09%) 9 <7> (+4) ⬆️
.../google/api/codegen/config/GapicProductConfig.java 79.04% <80%> (-0.08%) 92 <0> (ø)
.../java/com/google/api/codegen/discovery/Schema.java 84.84% <0%> (+0.5%) 43% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff5417c...dd2f082. Read the comment docs.

@@ -13,6 +13,7 @@ _COMPILE_DEPS = [
"@com_fasterxml_jackson_core_jackson_databind//jar",
"@com_google_api_api_common//jar",
"@com_google_api_api_compiler//jar",
"@com_google_api_api_compiler_testing//jar",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems odd to have a testing jar in the main deps. This is needed for the baseline differ? Is that to provide more user-friendly error output?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yah it's pretty and I figure our team is familiar with the look of the output.

@andreamlin andreamlin merged commit 64669ab into googleapis:gapic_config_v2 Apr 9, 2019
@andreamlin andreamlin deleted the validate_config_v2 branch April 9, 2019 17:48
andreamlin added a commit that referenced this pull request Apr 22, 2019
* Add Gapic config v2 (#2665)
* Whittling down config_v2 (#2666)
* Add ConfigV2 Validator (#2672)
* AutoValue LongRunningConfig; always use gapic config's polling settings (#2698)
* ResourceNameOneofConfig fixes (#2704)
* Start parsing GAPIC config v2 (#2703)
* Bring back timeout millis in GAPIC config v2 (#2708)
* Resource names across different protofiles (#2711)
* Fix missing default retries (#2718)
* Bug fixes for gapic config v2 parsing (#2717)
busunkim96 pushed a commit to busunkim96/gapic-generator that referenced this pull request Nov 7, 2019
* Add Gapic config v2 (googleapis#2665)
* Whittling down config_v2 (googleapis#2666)
* Add ConfigV2 Validator (googleapis#2672)
* AutoValue LongRunningConfig; always use gapic config's polling settings (googleapis#2698)
* ResourceNameOneofConfig fixes (googleapis#2704)
* Start parsing GAPIC config v2 (googleapis#2703)
* Bring back timeout millis in GAPIC config v2 (googleapis#2708)
* Resource names across different protofiles (googleapis#2711)
* Fix missing default retries (googleapis#2718)
* Bug fixes for gapic config v2 parsing (googleapis#2717)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants