This repository was archived by the owner on Jun 28, 2022. It is now read-only.
Fix missing default retries #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
michaelbausor
commented
Apr 17, 2019
michaelbausor
commented
- Always add default retry codes for idempotent and non-idempotent cases, so that when these codes are not present in the gapic config they will still be present and usable.
- Minor refactoring to reduce code re-use.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## gapic_config_v2 #2718 +/- ##
=====================================================
- Coverage 86.98% 86.97% -0.01%
- Complexity 5642 5643 +1
=====================================================
Files 469 469
Lines 22499 22499
Branches 2436 2436
=====================================================
- Hits 19571 19569 -2
- Misses 2080 2081 +1
- Partials 848 849 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## gapic_config_v2 #2718 +/- ##
=====================================================
+ Coverage 86.98% 87.02% +0.04%
Complexity 5642 5642
=====================================================
Files 469 469
Lines 22499 22481 -18
Branches 2436 2431 -5
=====================================================
- Hits 19571 19565 -6
+ Misses 2080 2072 -8
+ Partials 848 844 -4
Continue to review full report at Codecov.
|
alexander-fenster
approved these changes
Apr 17, 2019
evaogbe
approved these changes
Apr 19, 2019
andreamlin
added a commit
that referenced
this pull request
Apr 22, 2019
* Add Gapic config v2 (#2665) * Whittling down config_v2 (#2666) * Add ConfigV2 Validator (#2672) * AutoValue LongRunningConfig; always use gapic config's polling settings (#2698) * ResourceNameOneofConfig fixes (#2704) * Start parsing GAPIC config v2 (#2703) * Bring back timeout millis in GAPIC config v2 (#2708) * Resource names across different protofiles (#2711) * Fix missing default retries (#2718) * Bug fixes for gapic config v2 parsing (#2717)
busunkim96
pushed a commit
to busunkim96/gapic-generator
that referenced
this pull request
Nov 7, 2019
* Add Gapic config v2 (googleapis#2665) * Whittling down config_v2 (googleapis#2666) * Add ConfigV2 Validator (googleapis#2672) * AutoValue LongRunningConfig; always use gapic config's polling settings (googleapis#2698) * ResourceNameOneofConfig fixes (googleapis#2704) * Start parsing GAPIC config v2 (googleapis#2703) * Bring back timeout millis in GAPIC config v2 (googleapis#2708) * Resource names across different protofiles (googleapis#2711) * Fix missing default retries (googleapis#2718) * Bug fixes for gapic config v2 parsing (googleapis#2717)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.