This repository was archived by the owner on Jun 28, 2022. It is now read-only.
AutoValue LongRunningConfig; always use gapic config's polling settings #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
PTAL |
michaelbausor
approved these changes
Apr 7, 2019
| } | ||
|
|
||
| double pollDelayMultiplier = longRunningConfigProto.getPollDelayMultiplier(); | ||
| if (pollDelayMultiplier <= 1.0) { |
There was a problem hiding this comment.
This causes a failure if pollDelayMultiplier == 1.0, but the comment in the error says that 1.0 is valid - they should be consistent. (I realize this was just taken from below, but let's fix it!)
Codecov Report
@@ Coverage Diff @@
## gapic_config_v2 #2698 +/- ##
=====================================================
+ Coverage 86.71% 86.72% +<.01%
- Complexity 5585 5587 +2
=====================================================
Files 467 467
Lines 22350 22363 +13
Branches 2433 2430 -3
=====================================================
+ Hits 19381 19394 +13
Misses 2105 2105
Partials 864 864
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## gapic_config_v2 #2698 +/- ##
=====================================================
+ Coverage 86.71% 86.72% +<.01%
- Complexity 5585 5587 +2
=====================================================
Files 467 467
Lines 22350 22363 +13
Branches 2433 2430 -3
=====================================================
+ Hits 19381 19394 +13
Misses 2105 2105
Partials 864 864
Continue to review full report at Codecov.
|
andreamlin
added a commit
that referenced
this pull request
Apr 22, 2019
* Add Gapic config v2 (#2665) * Whittling down config_v2 (#2666) * Add ConfigV2 Validator (#2672) * AutoValue LongRunningConfig; always use gapic config's polling settings (#2698) * ResourceNameOneofConfig fixes (#2704) * Start parsing GAPIC config v2 (#2703) * Bring back timeout millis in GAPIC config v2 (#2708) * Resource names across different protofiles (#2711) * Fix missing default retries (#2718) * Bug fixes for gapic config v2 parsing (#2717)
busunkim96
pushed a commit
to busunkim96/gapic-generator
that referenced
this pull request
Nov 7, 2019
* Add Gapic config v2 (googleapis#2665) * Whittling down config_v2 (googleapis#2666) * Add ConfigV2 Validator (googleapis#2672) * AutoValue LongRunningConfig; always use gapic config's polling settings (googleapis#2698) * ResourceNameOneofConfig fixes (googleapis#2704) * Start parsing GAPIC config v2 (googleapis#2703) * Bring back timeout millis in GAPIC config v2 (googleapis#2708) * Resource names across different protofiles (googleapis#2711) * Fix missing default retries (googleapis#2718) * Bug fixes for gapic config v2 parsing (googleapis#2717)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a non-default GAPIC LRO config is given for a method, always use those polling settings. The gapic config is the only place where LRO polling settings can be defined
metadata and return type are defined by either the protofile's annotations or the GAPIC config.
this reduces the diff between API clients on gapic config v1 and gapic config v2