-
Notifications
You must be signed in to change notification settings - Fork 130
go: fix ignored page token bug in iterator #2716
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2716 +/- ##
=========================================
Coverage 86.95% 86.95%
Complexity 5622 5622
=========================================
Files 468 468
Lines 22446 22446
Branches 2433 2433
=========================================
Hits 19519 19519
Misses 2079 2079
Partials 848 848 Continue to review full report at Codecov.
|
3 similar comments
Codecov Report
@@ Coverage Diff @@
## master #2716 +/- ##
=========================================
Coverage 86.95% 86.95%
Complexity 5622 5622
=========================================
Files 468 468
Lines 22446 22446
Branches 2433 2433
=========================================
Hits 19519 19519
Misses 2079 2079
Partials 848 848 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2716 +/- ##
=========================================
Coverage 86.95% 86.95%
Complexity 5622 5622
=========================================
Files 468 468
Lines 22446 22446
Branches 2433 2433
=========================================
Hits 19519 19519
Misses 2079 2079
Partials 848 848 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2716 +/- ##
=========================================
Coverage 86.95% 86.95%
Complexity 5622 5622
=========================================
Files 468 468
Lines 22446 22446
Branches 2433 2433
=========================================
Hits 19519 19519
Misses 2079 2079
Partials 848 848 Continue to review full report at Codecov.
|
I'll let @jadekler sign off, but this LGTM. |
A mirror of the fix submitted in gapic-generator-go#128, the
PageToken
was not being respected at iterator creation. It was being ignored entirely if supplied when creating a new iterator.added @jadekler for approval of changes to generated output. This is technically a bug in all Go GAPICs today. We will need to regen once the change is released.