Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

go: fix ignored page token bug in iterator #2716

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

noahdietz
Copy link
Contributor

A mirror of the fix submitted in gapic-generator-go#128, the PageToken was not being respected at iterator creation. It was being ignored entirely if supplied when creating a new iterator.

added @jadekler for approval of changes to generated output. This is technically a bug in all Go GAPICs today. We will need to regen once the change is released.

@noahdietz noahdietz requested review from pongad and jeanbza April 17, 2019 00:54
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 17, 2019
@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #2716 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2716   +/-   ##
=========================================
  Coverage     86.95%   86.95%           
  Complexity     5622     5622           
=========================================
  Files           468      468           
  Lines         22446    22446           
  Branches       2433     2433           
=========================================
  Hits          19519    19519           
  Misses         2079     2079           
  Partials        848      848

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c624cde...8e8ecd9. Read the comment docs.

3 similar comments
@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #2716 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2716   +/-   ##
=========================================
  Coverage     86.95%   86.95%           
  Complexity     5622     5622           
=========================================
  Files           468      468           
  Lines         22446    22446           
  Branches       2433     2433           
=========================================
  Hits          19519    19519           
  Misses         2079     2079           
  Partials        848      848

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c624cde...8e8ecd9. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #2716 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2716   +/-   ##
=========================================
  Coverage     86.95%   86.95%           
  Complexity     5622     5622           
=========================================
  Files           468      468           
  Lines         22446    22446           
  Branches       2433     2433           
=========================================
  Hits          19519    19519           
  Misses         2079     2079           
  Partials        848      848

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c624cde...8e8ecd9. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #2716 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2716   +/-   ##
=========================================
  Coverage     86.95%   86.95%           
  Complexity     5622     5622           
=========================================
  Files           468      468           
  Lines         22446    22446           
  Branches       2433     2433           
=========================================
  Hits          19519    19519           
  Misses         2079     2079           
  Partials        848      848

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c624cde...8e8ecd9. Read the comment docs.

@pongad
Copy link
Contributor

pongad commented Apr 17, 2019

I'll let @jadekler sign off, but this LGTM.

@noahdietz noahdietz merged commit bcdf090 into googleapis:master Apr 17, 2019
@noahdietz noahdietz deleted the go-page-token-bug branch April 17, 2019 20:01
busunkim96 pushed a commit to busunkim96/gapic-generator that referenced this pull request Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants