-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing initialization of variables in classes/structs found by Cppcheck #43636
Comments
Hi. I am new to contributing to godot and would like to work on this issue. |
Entire |
Nice. I have already started working on the |
What is the progress in this issue? Is the issue fixed? If not, I would like to lend a hand. |
Looks that all folders which contains Cppcheck errors have already closed or still open PR which will fix them. |
I noticed that this problem was still open. I would like to help if possible or has everything been checked and closed already? |
Hi. I am new to contributing to Godot and would like to work on this issue if the problem is still open. |
Is any help still needed with this issue? @qarmin |
Is this still being worked on? @qarmin |
I’ll work on this! |
Godot version:
4.0.dev.custom_build.dd5485142
Issue description:
A lot of variables(812 but some are not counted and some are false positives) aren't initialized in constructors or directly where there are created in classe like(look at non initialized
left
variable which should be nullptr):godot/core/math/quick_hull.h
Line 73 in 90edd83
which may cause(and caused before) hard to reproduce errors.
How to fix them?
Member variable 'FaceConnect::left' is not initialized in the constructor.
and initialize this variable with default values likeshould be changed to
not (it is harder to read)
You can also move some value initialization from constructors to place where are created in structs/classes.
Cppcheck Report
Cppcheck report to download(remove .zip extension) - report.7z.zip
To view results, just open index.html file and only select at the left side
uninitMemberVar
Command which I used to generate this report
The text was updated successfully, but these errors were encountered: