Initialize variables in servers/audio
#52639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qarmin
force-pushed
the
cppcheck_servers_audio
branch
from
69fb5b3 to
869507c
Compare
AaronRecord
reviewed
Sep 13, 2021
| float sampling_rate; | ||
| int stages; | ||
| Mode mode; | ||
| float cutoff = 5000.0; |
There was a problem hiding this comment.
Should these have an f suffix since they are floats?
There was a problem hiding this comment.
I can add it, but it is really needed?
Looks that both, with and without f, produce same assembly in godbolt
AaronRecord
reviewed
Sep 13, 2021
qarmin
force-pushed
the
cppcheck_servers_audio
branch
from
869507c to
9ac02db
Compare
|
Currently I don't have enough time to rebase such commits, so feel free to use them to create new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #43636
I'm doing smaller patches, because rebasing against changes is master branch are easier.