Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize partially servers/rendering #52750

Closed
wants to merge 1 commit into from

Conversation

qarmin
Copy link
Contributor

@qarmin qarmin commented Sep 16, 2021

Part of #43636

-300 lines

@qarmin qarmin added this to the 4.0 milestone Sep 16, 2021
@qarmin qarmin requested a review from a team as a code owner September 16, 2021 18:55
@qarmin
Copy link
Contributor Author

qarmin commented Sep 17, 2021

Hmmm....
Looks that it broke shaders when running editor in CI(or which is less likely, unexposed bug with them)

SHADER ERROR: Expected 'shader_type' at the beginning of shader. Valid types are: 'canvas_item', 'particles', 'sky', 'spatial'
          at: (null) (:15)
ERROR: Shader compilation failed.

Fixed, I removed from data from clear method instead constructor

@qarmin qarmin force-pushed the rendering_1_more branch 3 times, most recently from b234caf to cf2c30a Compare September 17, 2021 06:03
@qarmin
Copy link
Contributor Author

qarmin commented Nov 30, 2021

Currently I don't have enough time to rebase such commits, so feel free to use them to create new PR.

@qarmin qarmin closed this Nov 30, 2021
@qarmin qarmin deleted the rendering_1_more branch November 30, 2021 14:26
@qarmin qarmin removed this from the 4.0 milestone Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant