Initialize class/struct variables with default values in platform/ and editor/ #43742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qarmin
force-pushed
the
editor_modules_default_values
branch
3 times, most recently
from
0c1a9d7 to
20444f9
Compare
qarmin
force-pushed
the
editor_modules_default_values
branch
from
20444f9 to
e1811b6
Compare
akien-mga
reviewed
Dec 8, 2020
| @@ -81,6 +81,8 @@ GotoLineDialog::GotoLineDialog() { | |||
| register_text_enter(line); | |||
| text_editor = nullptr; | |||
|
|
|||
| line_label = nullptr; | |||
There was a problem hiding this comment.
This one and the text_editor assignment would be better in the header.
akien-mga
reviewed
Dec 8, 2020
| @@ -626,6 +626,8 @@ DependencyErrorDialog::DependencyErrorDialog() { | |||
| vb->add_child(text); | |||
| text->set_text(TTR("Which action should be taken?")); | |||
|
|
|||
| mode = Mode::MODE_RESOURCE; | |||
akien-mga
reviewed
Dec 8, 2020
| @@ -963,6 +963,7 @@ EditorProperty::EditorProperty() { | |||
| selected_focusable = -1; | |||
| label_reference = nullptr; | |||
| bottom_editor = nullptr; | |||
| delete_hover = false; | |||
There was a problem hiding this comment.
All those should be moved to the header (but that's maybe out of scope of this PR, see #38697).
akien-mga
reviewed
Dec 8, 2020
Comment on lines
+1543
to
+1544
| const char *path = nullptr; | ||
| uint32_t keycode = 0; |
There was a problem hiding this comment.
This is actually unused and removed in #44128, so you might as well leave it out to avoid conflicts.
akien-mga
approved these changes
Dec 8, 2020
|
Let's merge as is, the initializations in constructor for |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #43636
Number of errors decreased by 77 (812 -> 735)