Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dome versions #39

Merged
merged 5 commits into from
Aug 6, 2020
Merged

Update Dome versions #39

merged 5 commits into from
Aug 6, 2020

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jul 27, 2020

Update gazebo and transport versions for Dome.

Signed-off-by: Nate Koenig [email protected]

Signed-off-by: Nate Koenig <[email protected]>
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Jul 27, 2020
@chapulina chapulina requested review from chapulina and j-rivero July 27, 2020 18:44
@chapulina
Copy link
Contributor

chapulina commented Jul 27, 2020

This requires:

Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor

@osrf-jenkins run tests please

@chapulina
Copy link
Contributor

@chapulina
Copy link
Contributor

@osrf-jenkins run tests please

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #39 into master will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   28.15%   28.03%   -0.12%     
==========================================
  Files           3        3              
  Lines         721      724       +3     
==========================================
  Hits          203      203              
- Misses        518      521       +3     
Impacted Files Coverage Δ
src/vendor/backward.hpp 9.00% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a284b73...f52c9f3. Read the comment docs.

@j-rivero
Copy link
Contributor

j-rivero commented Aug 5, 2020

Ok, all CI is happy except:

  • ubuntu_auto: needs patching, running the test for the fix here Build Status
  • Action for Focal: it requires fixes from ign-launch2 branch. It's going to be much easier to merge this first and do the forward port after.

@j-rivero
Copy link
Contributor

j-rivero commented Aug 5, 2020

There is only one cmake warning left in the CI that require a bit more of work to be fixed.
Ubuntu should be fixed after gazebo-tooling/release-tools#259. Ready to merge.

@chapulina
Copy link
Contributor

Copied the fix from bombela/backward-cpp#165 on f52c9f3 to fix the Focal build.

@chapulina chapulina merged commit 10f21df into master Aug 6, 2020
@chapulina chapulina deleted the dome_version_update branch August 6, 2020 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants