Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ignition-dome Formula. Update launch3 nightly. #1063

Merged
merged 15 commits into from
Aug 8, 2020
Merged

Add ignition-dome Formula. Update launch3 nightly. #1063

merged 15 commits into from
Aug 8, 2020

Conversation

j-rivero
Copy link
Collaborator

Part of the works of bumping infra for new versions of Dome gazebo-tooling/gazebodistro#5

chapulina
chapulina reviewed Jun 29, 2020
View reviewed changes
Formula/ignition-dome.rb Outdated Show resolved Hide resolved
Formula/ignition-dome.rb Outdated Show resolved Hide resolved
Formula/ignition-gazebo4.rb Outdated Show resolved Hide resolved
j-rivero and others added 3 commits July 9, 2020 20:05
@j-rivero j-rivero requested a review from chapulina July 9, 2020 18:07
This was referenced Jul 10, 2020
Merged
Merged
chapulina
chapulina reviewed Jul 10, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look good to me. I think that before merging we'll need to update the commit on all formula URLs

@chapulina chapulina mentioned this pull request Jul 16, 2020
Merged
chapulina
chapulina reviewed Jul 16, 2020
View reviewed changes
Aliases/ignition-msgs@6 Outdated Show resolved Hide resolved
Formula/ignition-transport9.rb Outdated Show resolved Hide resolved
chapulina
chapulina reviewed Jul 21, 2020
View reviewed changes
Formula/ignition-gui4.rb Outdated Show resolved Hide resolved
@chapulina chapulina mentioned this pull request Jul 21, 2020
Merged
@chapulina chapulina mentioned this pull request Jul 29, 2020
Merged
@chapulina chapulina changed the base branch from master to chapulina/dome/gazebo July 29, 2020 16:26
Base automatically changed from chapulina/dome/gazebo to master July 31, 2020 16:39
@chapulina
merged from master
7637669 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
bump ign-launch commit
2f8acd3 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor

Needs this: gazebosim/ign-dome#2

@chapulina
fix style
0ae6baa 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina mentioned this pull request Aug 4, 2020
Merged
@j-rivero j-rivero changed the title Update formulas/aliases for ignition-dome Add ignition-dome Formula. Update launch3 nightly. Aug 5, 2020
@j-rivero
Copy link
Collaborator Author

j-rivero commented Aug 7, 2020

CI is green! :)

@j-rivero j-rivero requested a review from chapulina August 7, 2020 15:08
@chapulina chapulina merged commit cfd8912 into master Aug 8, 2020
@chapulina chapulina deleted the dome branch August 8, 2020 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-rivero @chapulina