Dome version update #262

nkoenig · 2020-07-27T18:24:24Z

This updates required versions for Dome.

chapulina · 2020-07-27T23:38:04Z

This requires:

Update deps for Dome: use msgs6, transport9, sdf10 gz-sensors#31
An ign-sensors4 nightly release with ☝️
A homebrew-simulation commit update: ignition-gazebo4: bump for msgs6, transport9, sdf10, fuel5, physics3 osrf/homebrew-simulation#1079

j-rivero · 2020-07-29T16:28:48Z

This requires:

we might need to update to ign-physics3 before merging

2020-07-29T15:57:55.0423009Z  libignition-physics2-dev : Depends: libignition-physics2-dartsim-dev but it is not going to be installed
2020-07-29T15:57:55.0423472Z                             Depends: libignition-physics2-sdf-dev but it is not going to be installed
2020-07-29T15:57:55.0423965Z  libsdformat10-dev : Depends: libsdformat10 (= 10.0.0~pre1+nightly+git20200728+1r0f926078fd82ff34087f29350c387f999ac8a50d-1~bionic) but it is not going to be installed
2020-07-29T15:57:55.0542525Z E: Unable to correct problems, you have held broken packages.

Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: Jose Luis Rivero <[email protected]>

Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: Jose Luis Rivero <[email protected]>

Signed-off-by: Jose Luis Rivero <[email protected]>

j-rivero · 2020-07-29T21:19:08Z

we might need to update to ign-physics3 before merging

physics3 problem is solved. I just add support for bionic in fuel-tools5, waiting in Jenkins to be built, that should make github actions happy (pending on X support for tests or disable them).

Signed-off-by: Louise Poubel <[email protected]>

j-rivero · 2020-07-30T20:13:44Z

action is failing for tests:

2020-07-30T19:24:32.6186403Z The following tests FAILED:
2020-07-30T19:24:32.6186676Z 	 23 - UNIT_Server_TEST (Failed)
2020-07-30T19:24:32.6186953Z 	 39 - INTEGRATION_air_pressure_system (Failed)
2020-07-30T19:24:32.6187228Z 	 41 - INTEGRATION_altimeter_system (SEGFAULT)
2020-07-30T19:24:32.6187564Z 	 43 - INTEGRATION_apply_joint_force_system (SEGFAULT)
2020-07-30T19:24:32.6187855Z 	 45 - INTEGRATION_battery_plugin (SEGFAULT)
2020-07-30T19:24:32.6188119Z 	 47 - INTEGRATION_breadcrumbs (Failed)
2020-07-30T19:24:32.6188390Z 	 51 - INTEGRATION_contact_system (Failed)
2020-07-30T19:24:32.6188664Z 	 53 - INTEGRATION_detachable_joint (Failed)
2020-07-30T19:24:32.6188937Z 	 55 - INTEGRATION_diff_drive_system (Failed)
2020-07-30T19:24:32.6189205Z 	 63 - INTEGRATION_examples_build (Failed)
2020-07-30T19:24:32.6189479Z 	 65 - INTEGRATION_follow_actor_system (Failed)
2020-07-30T19:24:32.6189735Z 	 67 - INTEGRATION_imu_system (SEGFAULT)
2020-07-30T19:24:32.6190020Z 	 69 - INTEGRATION_joint_controller_system (Failed)
2020-07-30T19:24:32.6190293Z 	 71 - INTEGRATION_lift_drag_system (Failed)
2020-07-30T19:24:32.6190571Z 	 79 - INTEGRATION_logical_camera_system (SEGFAULT)
2020-07-30T19:24:32.6190849Z 	 81 - INTEGRATION_magnetometer_system (SEGFAULT)
2020-07-30T19:24:32.6191124Z 	 85 - INTEGRATION_multicopter (SEGFAULT)
2020-07-30T19:24:32.6191399Z 	 87 - INTEGRATION_network_handshake (Failed)
2020-07-30T19:24:32.6191671Z 	 89 - INTEGRATION_performer_detector (Failed)
2020-07-30T19:24:32.6191943Z 	 91 - INTEGRATION_physics_system (SEGFAULT)
2020-07-30T19:24:32.6192219Z 	 95 - INTEGRATION_pose_publisher_system (Failed)
2020-07-30T19:24:32.6192485Z 	 97 - INTEGRATION_save_world (Failed)
2020-07-30T19:24:32.6192769Z 	 99 - INTEGRATION_scene_broadcaster_system (Failed)
2020-07-30T19:24:32.6193043Z 	105 - INTEGRATION_thermal_system (Failed)
2020-07-30T19:24:32.6193308Z 	107 - INTEGRATION_touch_plugin (Failed)
2020-07-30T19:24:32.6193583Z 	109 - INTEGRATION_triggered_publisher (Failed)
2020-07-30T19:24:32.6193855Z 	111 - INTEGRATION_user_commands (SEGFAULT)
2020-07-30T19:24:32.6194108Z 	113 - INTEGRATION_log_system (SEGFAULT)
2020-07-30T19:24:32.6194375Z 	115 - INTEGRATION_wind_effects (Failed)
2020-07-30T19:24:32.6194640Z 	119 - PERFORMANCE_level_manager (Failed)

@chapulina do we want to add xfvb support or just disable them in github actions? There are many errors coming from the fact of not being able to find plugins.

j-rivero · 2020-07-30T20:14:06Z

@osrf-jenkins run tests please

j-rivero · 2020-07-30T21:14:24Z

@chapulina do we want to add xfvb support or just disable them in github actions? There are many errors coming from the fact of not being able to find plugins.

testing it here 1734811

Signed-off-by: Louise Poubel <[email protected]>

codecov · 2020-07-31T17:09:52Z

Codecov Report

Merging #262 into master will increase coverage by 15.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #262       +/-   ##
===========================================
+ Coverage   65.78%   80.79%   +15.01%     
===========================================
  Files         128      176       +48     
  Lines        6307     9229     +2922     
===========================================
+ Hits         4149     7457     +3308     
+ Misses       2158     1772      -386

Impacted Files	Coverage Δ
include/ignition/gazebo/components/Actor.hh	`27.27% <ø> (ø)`
...nclude/ignition/gazebo/components/ChildLinkName.hh	`100.00% <ø> (ø)`
include/ignition/gazebo/components/Name.hh	`100.00% <ø> (ø)`
...clude/ignition/gazebo/components/ParentLinkName.hh	`100.00% <ø> (ø)`
...de/ignition/gazebo/components/PerformerAffinity.hh	`100.00% <ø> (ø)`
.../ignition/gazebo/components/PhysicsEnginePlugin.hh	`100.00% <ø> (ø)`
...clude/ignition/gazebo/components/SourceFilePath.hh	`100.00% <ø> (ø)`
...ude/ignition/gazebo/components/LevelEntityNames.hh	`100.00% <100.00%> (ø)`
...nclude/ignition/gazebo/components/Serialization.hh	`100.00% <100.00%> (ø)`
src/systems/apply_joint_force/ApplyJointForce.hh	`100.00% <0.00%> (ø)`
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aea1acc...2155d62. Read the comment docs.

j-rivero · 2020-07-31T18:55:29Z

Looking into the failures for linux and brew.

j-rivero · 2020-07-31T21:59:23Z

@osrf-jenkins run tests

j-rivero · 2020-08-03T15:14:37Z

@osrf-jenkins run tests

j-rivero · 2020-08-03T15:35:03Z

the fail on Linux is expected (docker cache not being updated correctly). I'm testing a permanent fix in next builds.

j-rivero · 2020-08-03T16:14:53Z

wew! finally get all the CI mechanisms working. Merging and going for launch.

chapulina

🚢 it

nkoenig requested review from j-rivero and chapulina July 27, 2020 18:24

nkoenig requested a review from maryaB-osr as a code owner July 27, 2020 18:24

github-actions bot added the 🔮 dome Ignition Dome label Jul 27, 2020

chapulina mentioned this pull request Jul 27, 2020

Update Dome versions gazebosim/gz-launch#39

Merged

j-rivero self-assigned this Jul 28, 2020

chapulina mentioned this pull request Jul 29, 2020

ignition-gazebo4: bump for msgs6, transport9, sdf10, fuel5, physics3 osrf/homebrew-simulation#1079

Merged

chapulina and others added 6 commits July 29, 2020 23:06

Names with spaces: add string serializer (#244)

cacbf32

Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: Jose Luis Rivero <[email protected]>

Update to Dome versions

2534778

Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: Jose Luis Rivero <[email protected]>

More version updates

1e47fd9

Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: Jose Luis Rivero <[email protected]>

Update dependencies in workflows

b808f77

Signed-off-by: Jose Luis Rivero <[email protected]>

use fuel-tools5 and physics3

0f4fa6b

Signed-off-by: Jose Luis Rivero <[email protected]>

physics3 usage

a21ac7f

Signed-off-by: Jose Luis Rivero <[email protected]>

j-rivero force-pushed the dome_version_update branch from eb13e4d to a21ac7f Compare July 29, 2020 21:07

Add missing deps

3a540cf

Signed-off-by: Louise Poubel <[email protected]>

Add X support

1734811

chapulina added 3 commits July 30, 2020 16:36

sdf10 in examples

2577de9

Signed-off-by: Louise Poubel <[email protected]>

Merge branch 'master' into dome_version_update

df2c2c8

IGN_CONFIG_PATH

2155d62

Signed-off-by: Louise Poubel <[email protected]>

j-rivero mentioned this pull request Jul 31, 2020

Use sdf10 in physics3 dependencies_archive gazebo-tooling/release-tools#252

Merged

j-rivero mentioned this pull request Jul 31, 2020

Add ign-physics3 formula for Dome osrf/homebrew-simulation#1084

Merged

j-rivero mentioned this pull request Aug 3, 2020

Update msgs6 to latest commit osrf/homebrew-simulation#1086

Merged

j-rivero mentioned this pull request Aug 3, 2020

Fix gzdev to get changes in repositories when docker cache is old gazebo-tooling/release-tools#254

Merged

chapulina approved these changes Aug 3, 2020

View reviewed changes

j-rivero merged commit 8ec8d66 into master Aug 3, 2020

j-rivero deleted the dome_version_update branch August 3, 2020 17:26

mcres mentioned this pull request Aug 10, 2020

Unable to find URI (Fuel models) #280

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dome version update #262

Dome version update #262

nkoenig commented Jul 27, 2020

chapulina commented Jul 27, 2020 •

edited

Loading

j-rivero commented Jul 29, 2020

j-rivero commented Jul 29, 2020

j-rivero commented Jul 30, 2020

j-rivero commented Jul 30, 2020

j-rivero commented Jul 30, 2020

codecov bot commented Jul 31, 2020 •

edited

Loading

j-rivero commented Jul 31, 2020

j-rivero commented Jul 31, 2020

j-rivero commented Aug 3, 2020

j-rivero commented Aug 3, 2020

j-rivero commented Aug 3, 2020

chapulina left a comment

Dome version update #262

Dome version update #262

Conversation

nkoenig commented Jul 27, 2020

chapulina commented Jul 27, 2020 • edited Loading

j-rivero commented Jul 29, 2020

j-rivero commented Jul 29, 2020

j-rivero commented Jul 30, 2020

j-rivero commented Jul 30, 2020

j-rivero commented Jul 30, 2020

codecov bot commented Jul 31, 2020 • edited Loading

Codecov Report

j-rivero commented Jul 31, 2020

j-rivero commented Jul 31, 2020

j-rivero commented Aug 3, 2020

j-rivero commented Aug 3, 2020

j-rivero commented Aug 3, 2020

chapulina left a comment

Choose a reason for hiding this comment

chapulina commented Jul 27, 2020 •

edited

Loading

codecov bot commented Jul 31, 2020 •

edited

Loading