Names with spaces: add string serializer #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
==========================================
+ Coverage 65.78% 65.82% +0.03%
==========================================
Files 128 128
Lines 6307 6314 +7
==========================================
+ Hits 4149 4156 +7
Misses 2158 2158
Continue to review full report at Codecov.
|
|
It did fix the errors being printed, however multiple models with spaces are still rendered incorrectly, i.e. the sdf snippet wrote in the issue renders as below:
Edit: Actually nevermind I believe it is just an issue with the asset and its use of material scripts for alpha textures that is not supported anymore in ignition |
luca-della-vedova
approved these changes
Jul 15, 2020
iche033
reviewed
Jul 16, 2020
Signed-off-by: Louise Poubel <[email protected]>
…tics/ign-gazebo into chapulina/string_serializer
|
@osrf-jenkins retest this please |
iche033
approved these changes
Jul 20, 2020
|
j-rivero
pushed a commit
that referenced
this pull request
Jul 29, 2020
Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: Jose Luis Rivero <[email protected]>
j-rivero
added a commit
that referenced
this pull request
Aug 3, 2020
* Names with spaces: add string serializer (#244) * Update to Dome versions * Update dependencies in workflows * Add X support to workflows Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: Jose Luis Rivero <[email protected]> Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #239 .
This needs to target Dome because changing the serializer from default to a custom string serializer breaks ABI.
Added some names with spaces and special characters to
fuel.sdfand everything seems to be in place: