Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dome install instructions #48

Merged
merged 13 commits into from
Aug 26, 2020
Merged

Dome install instructions #48

merged 13 commits into from
Aug 26, 2020

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Aug 4, 2020

Resolves #37 .

I recommend seeing the diff between citadel and dome:

meld citadel/ dome/

We should wait until there are ignition-dome Linux nightlies and an initial homebrew bottle before merging. The source instructions will be good to go once gazebosim/gz-launch#39 is in.

My main concern is that with the current site layout, Dome will show up on top of Citadel. It would be nice to be able to add notes next to the release names, like "unstable" and "LTS, recommended".

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added the documentation Improvements or additions to documentation label Aug 4, 2020
@chapulina chapulina requested review from nkoenig and maryaB-osr August 4, 2020 02:53
@chapulina chapulina added the 🔮 dome Ignition Dome label Aug 4, 2020
@chapulina chapulina requested a review from j-rivero August 4, 2020 02:54
dome/install_osx_src.md Outdated Show resolved Hide resolved
dome/install_osx_src.md Outdated Show resolved Hide resolved
dome/install_osx_src.md Outdated Show resolved Hide resolved
@zmk5
Copy link
Contributor

zmk5 commented Aug 5, 2020

Sorry for just kind of barging in with small fixes, but I attempted to do a source install with my Catalina installation and thought to give feedback on the macOS src installation.

@chapulina
Copy link
Contributor Author

Thanks for the feedback, @zmk5 ! Most of the Catalina instructions here were copied from the citadel ones:

https://github.com/ignitionrobotics/docs/blob/master/citadel/install_osx_src.md

I think we still need some updates on the source code for the instructions here to work for Dome. Do you mind checking the Citadel instructions and opening a PR for them if they need changes?

@zmk5
Copy link
Contributor

zmk5 commented Aug 6, 2020

So far if you follow the instructions with both Citadel and Dome, it will compile and install with no errors. However, attempting to run ign gazebo, ign gui, and ign launch, you will get dylib errors saying .../install/libignition-gazeboX-ign.X.0.0~pre1.dylib couldn't be loaded and libignition-guiX.dylib and libignition-launchX.dylib couldn't be found. All the other commands for ignition work except that one. I have a feeling this is a Qt issue and not an installation instruction issue because I get Policy CMP0079 warnings all the time for gui and gazebo builds.

I will make a PR for the citadel one for you though with my fixes!

@chapulina
Copy link
Contributor Author

I will make a PR for the citadel one for you though with my fixes!

Thanks!

attempting to run ign gazebo, ign gui, and ign launch, you will get dylib errors

This is being tracked on this issue, help is appreciated 😄 gazebosim/gz-sim#25

@zmk5
Copy link
Contributor

zmk5 commented Aug 6, 2020

Thanks Louise! I'll help as much as I can. I would really love to get ignition working on my mac.

@chapulina chapulina self-assigned this Aug 10, 2020
@chapulina chapulina marked this pull request as ready for review August 10, 2020 17:26
@chapulina
Copy link
Contributor Author

Thank you for all the reviews, we're holding on merging until we have a way to make it clear on the site that Dome is not the recommended version. CC @maryaB-osr

Signed-off-by: maryaB-osr <[email protected]>
chapulina and others added 3 commits August 21, 2020 16:39
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
@maryaB-osr
Copy link
Contributor

See #68, I think it'd be best to add Dome above Citadel to keep them in chronological order, and write Dome's description as "Upcoming release, under development" or "Latest features, not yet recommended", or something like that

@chapulina
Copy link
Contributor Author

best to add Dome above Citadel to keep them in chronological order,

Sounds good to me, let's get that one in first and then I adapt this one and address the remaining comments.

chapulina and others added 3 commits August 25, 2020 15:53
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Marya Belanger <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina changed the base branch from master to release-metadata August 25, 2020 23:11
Signed-off-by: Louise Poubel <[email protected]>
Base automatically changed from release-metadata to master August 25, 2020 23:39
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit b8349d1 into master Aug 26, 2020
@chapulina chapulina deleted the chapulina/dome/install branch August 26, 2020 00:00
@chapulina chapulina mentioned this pull request Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building upcoming collection from source
7 participants