-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dome install instructions #48
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Sorry for just kind of barging in with small fixes, but I attempted to do a source install with my Catalina installation and thought to give feedback on the macOS src installation. |
Thanks for the feedback, @zmk5 ! Most of the Catalina instructions here were copied from the citadel ones: https://github.com/ignitionrobotics/docs/blob/master/citadel/install_osx_src.md I think we still need some updates on the source code for the instructions here to work for Dome. Do you mind checking the Citadel instructions and opening a PR for them if they need changes? |
So far if you follow the instructions with both Citadel and Dome, it will compile and install with no errors. However, attempting to run I will make a PR for the citadel one for you though with my fixes! |
Thanks!
This is being tracked on this issue, help is appreciated 😄 gazebosim/gz-sim#25 |
Thanks Louise! I'll help as much as I can. I would really love to get ignition working on my mac. |
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Thank you for all the reviews, we're holding on merging until we have a way to make it clear on the site that Dome is not the recommended version. CC @maryaB-osr |
Signed-off-by: maryaB-osr <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
See #68, I think it'd be best to add Dome above Citadel to keep them in chronological order, and write Dome's description as "Upcoming release, under development" or "Latest features, not yet recommended", or something like that |
Sounds good to me, let's get that one in first and then I adapt this one and address the remaining comments. |
Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Marya Belanger <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Resolves #37 .
I recommend seeing the diff between
citadel
anddome
:meld citadel/ dome/
We should wait until there areignition-dome
Linux nightlies and an initial homebrew bottle before merging. The source instructions will be good to go once gazebosim/gz-launch#39 is in.My main concern is that with the current site layout, Dome will show up on top of Citadel. It would be nice to be able to add notes next to the release names, like "unstable" and "LTS, recommended".