forked from ethereum-optimism/optimism
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Po/fp devnet #151
Open
dajuguan
wants to merge
684
commits into
fp-devnet
Choose a base branch
from
po/fp-devnet
base: fp-devnet
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Po/fp devnet #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typo in build script comment for clarity
CI must passing should be CI must pass.
- fixing the audit commits and descriptions so they map correctly
Fix typo in comment for Keccak256Commitment.Encode method
…timism#12881) * typo corr 2022-02-02-inflation-vuln.md * typo corr README.md * typo corr RUNBOOK.md
* flatten out batcher goroutines * move wg increment to parent fn * ensure mainloop closes before receipts loop * add comments * pass a context to both loops * remove debug lines * clean up mutex handling in receiptsLoop * don't need to set default value the first time * avoid writing to Logger while holding mutex * typo * increase log level and include tx.ID * fix changes from merge, hoist throttling loop goroutine launch to driver * call done on waitgroup in throttlingLoop * move function around hoping this makes the diff nicer
…12430) * implement batchSubmitter.checkExpectedProgress * remove buffer variable * add warning logs when calling waitNodeSyncAndClearState * push method down into channel manager and add test * clarify SyncStatus documentation * improve TestChannelManager_CheckExpectedProgress make parameters "tighter" / more realistic and check an extra case
Conflicts: go.mod go.sum packages/contracts-bedrock/scripts/L2Genesis.s.sol packages/contracts-bedrock/scripts/checks/interfaces/main.go
…ethereum-optimism#12919) * Reset Derivation when Supervisor is Behind * Disable Batcher Throttling in Interop local-devnet
Adds a unit test for mainnet deployments at version 1.6.0.
…#12820) * interop: make geth Dockerfile use rc5 * use rc6 * Update ops-bedrock/l2-op-geth-interop.Dockerfile
It has been 6 months since we removed the package and added the redirect. Anybody that has not learned where it is at this point will be able to search Github and find a link to this commit.
…mism#12975) Co-authored-by: Samuel Laferriere <[email protected]>
Update the op-deployer Dockerfile to install CA certificates and symlink /op-deployer into /usr/local/bin so that it's on the container's PATH.
* migrate close-stale github action * using external script * completing script * removing old github action * example only * removing versions * removing tag-service
* feat(ctb): `RISCV.sol` semver-lock Co-Authored-By: Minhyuk Kim <[email protected]> Co-Authored-By: Taem Park <[email protected]> Co-Authored-By: Park Changwan <[email protected]> Co-Authored-By: protolambda <[email protected]> * snapshots * diff with remote in CI * schedule diff job * Update .circleci/config.yml Co-authored-by: Matt Solomon <[email protected]> * remove check changed --------- Co-authored-by: Minhyuk Kim <[email protected]> Co-authored-by: Taem Park <[email protected]> Co-authored-by: Park Changwan <[email protected]> Co-authored-by: protolambda <[email protected]> Co-authored-by: Matt Solomon <[email protected]>
Merge optimism 910c9ad
* improve delayedWeth test and coverage * improve delayedWeth test and coverage * fix DataAvailabilityChallenge failing fuzz test
…#12996) * improve universal and libraries tests and coverage * fixes
add allowSgtValue/disallowSgtValue to SGT contract
* SGT: add batchDepositForAll * follow op coding convention * address comment
* Revert "fix alt-da test" This reverts commit bf97d60. * add InboxContractConfig * add some comment
* feat: enable dac server in devnet * use latest da-server commit --------- Co-authored-by: Qi Zhou <[email protected]>
(TODO: resolve conflict in .circleci/config.yml) Conflicts: .circleci/config.yml go.mod go.sum op-batcher/batcher/driver.go op-service/txmgr/txmgr.go packages/contracts-bedrock/interfaces/L2/ISoulGasToken.sol packages/contracts-bedrock/test/setup/Setup.sol
* fix build of dac-server * use submodule * use submodule * refactor * revert refactor
* fix semver-lock * fix semver-lock.json
* SGT: add E2E tests * address comment * address comment * add vaultBalance diff check * address comment
* fix TestDencunBlobTxInclusion * fix DencunBlobTx
I guess you should prepare a PR to merge to op-es? |
If this merge necessary for devnet testing ? As normally we need to upgrade optimism and op-geth at the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
address issue ethstorage/pm#157
op-es
and fix conflict