Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve delayedWeth test and coverage #12963

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

AmadiMichael
Copy link
Member

I'm of the opinion that the withdraw(uint256) method used in DelayedWETH tests should be that of the DelayedWETH contract (which in turn calls the withdraw(address,uint256) method). SInce the former calls the latter, that means the latter is tested for too indirectly.
This helps with test coverage.

Other alternatives:

  • Write tests for withdraw(uint256) also which (the test) are basically a clone of that of withdraw(address,uint256)? This is also a better approach maybe since modifications to any of the 2 functions will be tested for already.
  • Leave it as is?

@AmadiMichael AmadiMichael requested a review from a team as a code owner November 19, 2024 08:45
@smartcontracts smartcontracts added this pull request to the merge queue Nov 20, 2024
Merged via the queue into develop with commit f3701d7 Nov 20, 2024
49 checks passed
@smartcontracts smartcontracts deleted the sc/improve-delayedWeth-test-cov branch November 20, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants