re-introduce InboxContractConfig #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bf97d60.
blockchaindevsh
force-pushed
the
add_back_UseInboxContract
branch
from
6cd314f to
1660aa2
Compare
|
Could you explain the motivation and tests that you have done? |
The inbox contract change is the main incompatible change that's causing upstream tests to fail. By adding back the optional inbox contract config, the upstream tests should all pass. As a result, the changes to the alt-da tests are no longer necessary, so I reverted it. I've also locally run the alt-da tests and As for the test with our features on, they're covered by #100 |
qizhou
approved these changes
Dec 11, 2024
qzhodl
reviewed
Dec 11, 2024
qzhodl
approved these changes
Dec 11, 2024
syntrust
pushed a commit
that referenced
this pull request
Dec 11, 2024
* Revert "fix alt-da test" This reverts commit bf97d60. * add InboxContractConfig * add some comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-introduces the inbox contract config which was remove here.
Fixes #118 and #110.