Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: set default versions to v0.0.0 #12989

Merged
merged 1 commit into from
Nov 20, 2024
Merged

go: set default versions to v0.0.0 #12989

merged 1 commit into from
Nov 20, 2024

Conversation

protolambda
Copy link
Contributor

Description

Previously:

go run ./op-node/cmd --version
op-node version v0.10.14-dev

The output here is misleading. This is a 2 year old hardcoded string.
When we build through a makefile / docker we override it, but by default we should print something that makes it more obvious it wasn't set, rather than using a very old version.

This changes it to v0.0.0 in each service.

@protolambda protolambda requested review from a team as code owners November 19, 2024 20:45
@mslipper mslipper enabled auto-merge November 20, 2024 00:12
@mslipper mslipper added this pull request to the merge queue Nov 20, 2024
Merged via the queue into develop with commit cccbc2d Nov 20, 2024
49 checks passed
@mslipper mslipper deleted the fix-default-versions branch November 20, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants