-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New "InputWrapper" component #2336
Labels
Comments
mimarz
added
core-react
eds-core-react
✨ enhancement
Enhancements for our existing components
labels
Jun 22, 2022
This was referenced Jun 22, 2022
This was referenced Jun 27, 2022
Closed
Converted this to epic as we have a few sub-tasks and testing that needs to be done with this change, aswell as created seperate branch for all work on this |
I think we should move the PR's connected to this Epic to an issue instead |
This was referenced Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Undecided on name, but I suggest we need a "inputWrapper" or "Field" like component which handles adornments, helpertext, label, meta and such for encompassing
Input
.We currently have
Search
,Autocomplete
,TextField
, which all have different implementations of how an input is rendered along with its helpertext (or not), adornments, labels etc.This makes it harder to maintain, ensure consistency and proper
a11y
.We also have several pending issues which could easily be solved by standardising with a
InputWrapper
;Goals
Textfield
has a similar component internally which might be extracted and usedRadio
,Checkbox
&Switch
Notes
InputWrapper
: https://mantine.dev/core/input-wrapper/FormControl
: https://mui.com/material-ui/api/form-control/The text was updated successfully, but these errors were encountered: