Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextField component displays the letter "Å" as "A" #2467

Closed
lemsa opened this issue Sep 6, 2022 · 9 comments
Closed

TextField component displays the letter "Å" as "A" #2467

lemsa opened this issue Sep 6, 2022 · 9 comments
Labels
🐛 bug Something isn't working core-react eds-core-react

Comments

@lemsa
Copy link

lemsa commented Sep 6, 2022

The letter Å is displayed as an "A" in the TextField component

Steps to reproduce the bug

  1. Open https://eds-storybook-react.azurewebsites.net/?path=/docs/inputs-textfield--introduction
  2. Go into the first TextField component there and write "Å". It is displayed as an "A". Overriding the font-family to something else than "Equinor" makes it display as an "Å", so the letter itself is correct, but the display is not.

Expected behavior

The letter "Å" and not "A" should be displayed.

Specifications

  • Version: 104
  • Browser: Chrome
  • OS: Windows 10 Enterprise
@lemsa lemsa added the 🐛 bug Something isn't working label Sep 6, 2022
@mimarz mimarz added the core-react eds-core-react label Sep 6, 2022
@mimarz
Copy link
Contributor

mimarz commented Sep 6, 2022

Hey! Thanks for reporting.

Do you have a screenshot to show us?
Can't seem to reproduce the bug. On a mac though 🤔

@lemsa
Copy link
Author

lemsa commented Sep 6, 2022

image

@lemsa
Copy link
Author

lemsa commented Sep 6, 2022

BTW - the letters: "å, Æ, æ, Ø, ø" are all okay. The only issue is with the letter "Å".

@mimarz
Copy link
Contributor

mimarz commented Sep 6, 2022

Looks like this here:
image

Would you have time for a call later to show us?

@lemsa
Copy link
Author

lemsa commented Sep 6, 2022

Sure - I am in Equinor Teams.

@mimarz
Copy link
Contributor

mimarz commented Sep 6, 2022

Sure - I am in Equinor Teams.

Super! We set up a meeting at 14.00 with me and @vnys to have a look at this peculiar bug 🐛🤔

@mimarz
Copy link
Contributor

mimarz commented Sep 6, 2022

Notes from DMs on Slack

  • Equinor managed windows laptop
  • 2560x1440 resolution

@lemsa
Copy link
Author

lemsa commented Sep 6, 2022

If I override the line-height in Developer tools in the textinput field from 1.5em to 2.25em, then the Å is displayed correctly.

However 1.5em is what we want...

@mimarz
Copy link
Contributor

mimarz commented Sep 6, 2022

After our meeting and testing using Equinor Citrix, it turns out that there is something with Equinor managed computers that disturbs the line-height and somehow clamps its. We were not able to find out the cause of this. Maybe it has something to do with the pre-installed font that come with Equinor managed computers.

We did find out that removing the fixed height on input resolved this line-height issue. This change has however already been done in our re-write of "inputs" with epic #2336 .

One important take away from this issue is that we need to also test our components via the Equinor Citrix.

Closing issue as this will be resolved when #2336 is released.

@mimarz mimarz closed this as completed Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working core-react eds-core-react
Projects
None yet
Development

No branches or pull requests

2 participants