Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select components: Add helpertext - document variant property #1660

Closed
Tracked by #2355
HansKristianVikOlsen opened this issue Oct 27, 2021 · 4 comments
Closed
Tracked by #2355

Select components: Add helpertext - document variant property #1660

HansKristianVikOlsen opened this issue Oct 27, 2021 · 4 comments
Labels
design ✨ enhancement Enhancements for our existing components 💡 feature request
Milestone
EDS 2.0

Comments

@HansKristianVikOlsen
Copy link

HansKristianVikOlsen commented Oct 27, 2021 •
edited
Loading

Similar to TextField component, it would be nice to have the same properties to the select components. This would be useful to display error messages and other info

image
@HansKristianVikOlsen
Copy link
Author

HansKristianVikOlsen commented Oct 27, 2021 •
edited
Loading

Ah sorry, it is just not documented in the storybook? Seems like variant works, but not helpertext

@HansKristianVikOlsen HansKristianVikOlsen changed the title Select components: Add helpertext and variant properties Select components: Add helpertext and variant properties - document variant property Oct 27, 2021
@HansKristianVikOlsen HansKristianVikOlsen changed the title Select components: Add helpertext and variant properties - document variant property Select components: Add helpertext - document variant property Oct 27, 2021
@mimarz
Copy link
Contributor

mimarz commented Oct 27, 2021

Thanks for the feedback!

I think we had this up for discussion when first designing the Selects and choose to not include helperText as it falls below the dropdown when opened. You raise a good point about where to display error and validation messages tho. We have how a issue (somewhere) on going through all of our components and getting a good foundation for validation/error/feedback messages.

@akvam akvam added the ✨ enhancement Enhancements for our existing components label May 18, 2022
@mimarz mimarz mentioned this issue Jun 22, 2022
Closed
@BirteThornquist
Copy link
Contributor

Select is changed to autocomplete.

@vnys vnys mentioned this issue Feb 8, 2023
Open
44 tasks
@vnys vnys added this to the EDS 2.0 milestone Feb 10, 2023
@oddvernes
Copy link
Collaborator

resolved by #3139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design ✨ enhancement Enhancements for our existing components 💡 feature request
Projects
None yet
Milestone
EDS 2.0
Development

No branches or pull requests
6 participants
@mimarz @vnys @oddvernes @akvam @HansKristianVikOlsen @BirteThornquist