Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conform on "Actions" sub-component #1199

Closed
mimarz opened this issue Apr 6, 2021 · 7 comments
Closed

Conform on "Actions" sub-component #1199

mimarz opened this issue Apr 6, 2021 · 7 comments
Labels
core-react eds-core-react

Comments

@mimarz
Copy link
Contributor

mimarz commented Apr 6, 2021

Determine usage and behaviour of "Actions" sub-components in our components. It looks to mostly be spacing and placements of actions (icons, buttons, etc)

Components with actions so far:

  • Dialog
  • Card
  • Popover
  • Banner
  • .... more?
@mimarz mimarz added the core-react eds-core-react label Sep 29, 2021
@vnys
Copy link
Member

vnys commented Feb 16, 2022

@laliq Is this a duplicate of the work you did with a while ago?

@akvam
Copy link

akvam commented Sep 21, 2022

Somebody that know if this is still relevant? @mimarz , @martalalik

@martalalik
Copy link
Contributor

I'm closing this issue this is a duplication, just like @vnys mentioned.

@mimarz
Copy link
Contributor Author

mimarz commented Sep 21, 2022

Well, some work has been done and some still remains, might be good for a newcomer issue or hacktober?

This is similar to work done with #1812 and #2336 or how we are using Paper in several of our components.

@mimarz mimarz reopened this Sep 21, 2022
@martalalik
Copy link
Contributor

Convert to an epic?

@mimarz
Copy link
Contributor Author

mimarz commented Sep 21, 2022

Convert to an epic?

Maybe do that evaluation when we move this out of the backlog. We have quite a few epics now already... 🤔

@oddvernes
Copy link
Collaborator

This will implicitly be fully resolved when we implement eds 2.0 tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-react eds-core-react
Projects
None yet
Development

No branches or pull requests

5 participants