Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete with readOnly cut off text #2294

Closed
wigsnes opened this issue Jun 9, 2022 · 2 comments
Closed

Autocomplete with readOnly cut off text #2294

wigsnes opened this issue Jun 9, 2022 · 2 comments
Assignees
Labels
🐛 bug Something isn't working core-react eds-core-react

Comments

@wigsnes
Copy link

wigsnes commented Jun 9, 2022

Describe the bug

Autocomplete with readOnly cut off text.

There is still available space where the text should be visible.

AutocompleteCutOff

@wigsnes wigsnes added the 🐛 bug Something isn't working label Jun 9, 2022
@mimarz mimarz added the core-react eds-core-react label Jun 13, 2022
@mimarz mimarz self-assigned this Jun 15, 2022
@mimarz
Copy link
Contributor

mimarz commented Jun 22, 2022

Dues to how adornments was implemented in Autocomplete, fixing this properly is kinda tricky. Postponing this for now as this should be solved by #2336

Edit: The problem was using to padding equal two two icons + 2 spacing for placement of interactive buttons for clear and open. This lead to the text being cut of visually. Changing the padding for readonly worked but led to input being bigger than its container and not properly adjusting to parents flexbox. This could be remedied by changing the box-sizing, but that lead to other styling problems...

@mimarz
Copy link
Contributor

mimarz commented Sep 20, 2022

We have decided not to fix this as we couldn't find a good way to solve this as "adornments" such as the dropdown caret or clear button needs to be absolute position to not disturb the input content.

For now we can live with this deficit as its only for readonly state, and text is still decipherable.

@mimarz mimarz closed this as completed Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working core-react eds-core-react
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants