Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete onOpen after selection showing wrong options #2373

Closed
mimarz opened this issue Jul 4, 2022 · 5 comments · Fixed by #2562
Closed

Autocomplete onOpen after selection showing wrong options #2373

mimarz opened this issue Jul 4, 2022 · 5 comments · Fixed by #2562
Assignees
Labels
🐛 bug Something isn't working core-react eds-core-react

Comments

@mimarz
Copy link
Contributor

mimarz commented Jul 4, 2022

After an selection in single select mode for Autocomplete all items are supposed to be shown. For some reason they are still showing filtered items.

Slack discussion ongoing with examples here: https://equinor.slack.com/archives/CJT20H1B9/p1656595261051539

@mimarz mimarz added 🐛 bug Something isn't working core-react eds-core-react labels Jul 4, 2022
@v3gard
Copy link

v3gard commented Aug 24, 2022

Is there a timeline for when we can expect a fix for this @mimarz?

@mimarz
Copy link
Contributor Author

mimarz commented Aug 24, 2022

I don't have a definitive answer for you except for that its the next batch of work in the pipeline for me after I finish #2336 and #2407 . The InputWrapper has tho taken up a lot more time than expected as there has been a lot of edge-cases and shortcomings of old components that needed to be fixed 😅 When I get to it is unsure, but very soon I hope!

@mimarz mimarz self-assigned this Sep 29, 2022
@v3gard
Copy link

v3gard commented Oct 6, 2022

A workaround for this issue is to add a EOL character after the label, e.g. U+00A0 (no-break-space).

Example

@mimarz
Copy link
Contributor Author

mimarz commented Oct 6, 2022

A workaround for this issue is to add a EOL character after the label, e.g. U+00A0 (no-break-space).

Example

Nice! Will be easier to track down whats actually wrong and a potential fix 👍

@mimarz
Copy link
Contributor Author

mimarz commented Oct 10, 2022

Hi @v3gard!

We are trying to simplify the logic thats bring used to determine wether to show all options or not.

I have forked your sandbox with an updated dev version so you can test if this would work for you.

We are now testing a new logic where;

  • If a value is typed but no option is selected, it will show filtered options.
  • If you have selected an option, it will show all options on re-open
  • If you start typing again after an option has been selected, the list will show filtered options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working core-react eds-core-react
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants