Fastcomp cleanup post removal #11860

sbc100 · 2020-08-11T18:32:28Z

As a followup to #11319 we have a lot of potential cleanup of emscripten to do now that fastcomp is no more.

One thing to consider: do we want to make backporting/cherrying picking easy(er) for while). Should we hold off large refactors for a while for this reason? It seem like there will be enough pure-deletion PRs to keep us going for while :)

List of cleanup work:

Remove asmjs validation (Remove asmjs validation #11551).
Remove JS in src/ inside !WASM_BACKEND
Remove check_vanilla and is_vanilla cache file, @sbc
Remove all Python driver code inside not WASM_BACKEND
Remove WASM_BACKEND completely.
Remove fastcomp-only settings in settings.js.
Remove dual/split cache (cache/asmjs vs cache/wasm)
Remove fastcomp backend code in emscripten.py.
Remove WASM? (even with -s WASM=0 we set WASM to 1 and set WASM2JS, in verify_settings. so WASM == 1 all the time in tests etc.)

Cleanup PRs should mention "See #11860" (this PR).

The text was updated successfully, but these errors were encountered:

kripken · 2020-08-11T18:36:22Z

I agree deletion PRs are a good starting point. That's low-risk, and enables more stuff later.

I don't think we should try to make backporting easier, as there seems little benefit. (If backporting is important to someone, would be good to hear about that, and how we can work together on it.)

I think we should coordinate those deletion PRs in this issue, to avoid stepping on each others' toes and getting lots of merge conflicts. For example: I can start with the JS code src/* - ?

sbc100 · 2020-08-11T18:38:21Z

Sounds good. Why don't we all work on the list above and put your name on a list item if you are going to start work on it? I am personally going to try to avoid the temptation to just do all of them right away :) (Mostly since I think it could suck all my time for the next month!)

See #11860

After removing it, things are always in DOUBLE_MODE == 1 basically (that is, doubles are normal doubles, no asm.js weirdness). See #11860

See #11860

See emscripten-core#11860

See #11860

#11860

This has been a no-op on wasm, and this PR keeps it that way (we do duplicate function elimination in binaryen automatically). See #11860

SEPARATE_ASM was always just an asm.js feature, and never worked in upstream.

…scripten.py fastcomp code around it. See #11860

This is no longer in use since fastcomp removal. See: #11860

See #11860

These are no longer used or usefull since fastcomp removal. See: #11860

Also remove functions and modules that were only used by this code. See: #11860

This was only used in fastcomp builds. AFAICT the llvm backend uses binaryen passes to do this stuff. See: #11860

Also remove functions and modules that were only used by this code. See: #11860

These are no longer used or usefull since fastcomp removal. See: #11860

This was only used in fastcomp builds. AFAICT the llvm backend uses binaryen passes to do this stuff. See: #11860

These are no longer used or usefull since fastcomp removal. See: #11860

These are no longer used or useful since fastcomp removal. See: #11860

See: #11860

These used to make sense when we had static allocations in JS. We'd use the "bump" to track the total size, which was increased by the JS compiler, and at runtime we'd have STATIC_BASE and STATICTOP. Now that we disallow static allocations from the JS compiler, we don't need them. Note that we do still track "staticBump" in the metadata from finalize. That is the total size of static memory from lld, which never changes. We use it to compute where the stack begins (which determines the rest of memory layout). As a followup we may be able to use a link map or other mechanism to just read that info instead of computing it in emscripten.py See #11860

This removes some TODOs from wasm2js where we thought about running more of the old passes. I think that's not a good idea - they will not run as our wasm2js output gets less and less like asm.js anyhow. We'll need to write new acorn passes there, if we want to. This removes safeHeap which we should be running (see #12410 (comment)), but as it would be the only thing we use the js optimizer for from emcc.py, and that isn't a recent regression, remove that too and I'll rewrite it for acorn. See #11860

See emscripten-core/emscripten#11860

stale · 2021-08-21T04:39:19Z

This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant.

This was referenced Aug 11, 2020

Remove fastcomp-only EMULATED_FUNCTION_POINTERS setting #11864

Merged

Remove fastcomp-only DOUBLE_MODE setting #11862

Merged

Remove asmjs validation #11551

Merged

kripken added a commit that referenced this issue Aug 11, 2020

Remove fastcomp-only EMULATED_FUNCTION_POINTERS setting (#11864)

c0470c7

See #11860

This was referenced Aug 11, 2020

Remove fastcomp-only FAST_UNROLLED_MEMCPY_AND_MEMSET setting #11861

Merged

Remove fastcomp-only CYBERDWARF option #11865

Merged

kripken added a commit that referenced this issue Aug 11, 2020

Remove fastcomp-only DOUBLE_MODE setting (#11862)

45d3f10

After removing it, things are always in DOUBLE_MODE == 1 basically (that is, doubles are normal doubles, no asm.js weirdness). See #11860

kripken added a commit that referenced this issue Aug 11, 2020

Remove fastcomp-only SEPARATE_ASM option. See #11860

20c99b8

kripken added a commit that referenced this issue Aug 11, 2020

Remove fastcomp-only FAST_UNROLLED_MEMCPY_AND_MEMSET setting (#11861)

de379ce

See #11860

kripken added a commit that referenced this issue Aug 11, 2020

Remove fastcomp-only CYBERDWARF option (#11865)

bd98714

See #11860

kripken added a commit that referenced this issue Aug 11, 2020

Remove fastcomp-only BINARYEN_TRAP_MODE. See #11860

f227d45

sbc100 mentioned this issue Aug 11, 2020

library_async.js cleanup #11867

Merged

kripken added a commit that referenced this issue Aug 11, 2020

Remove fastc-only ELIMINATE_DUPLICATE_FUNCTIONS option. See #11860

2a437e0

Akaricchi added a commit to Akaricchi/emscripten that referenced this issue Aug 12, 2020

Remove fastcomp-specific Asyncify code

1480779

See emscripten-core#11860

Akaricchi mentioned this issue Aug 12, 2020

Remove fastcomp-specific Asyncify code #11868

Merged

sbc100 pushed a commit that referenced this issue Aug 12, 2020

Remove fastcomp-specific Asyncify code (#11868)

9b5c5b9

See #11860

kripken mentioned this issue Aug 12, 2020

Remove fastcomp-only ELIMINATE_DUPLICATE_FUNCTIONS* options #11876

Merged

kripken added a commit that referenced this issue Aug 12, 2020

Remove some no-longer used test code that was missed in recent PRs. See

70bdf44

#11860

kripken added a commit that referenced this issue Aug 12, 2020

Remove fastcomp-only ELIMINATE_DUPLICATE_FUNCTIONS* options (#11876)

574f381

This has been a no-op on wasm, and this PR keeps it that way (we do duplicate function elimination in binaryen automatically). See #11860

kripken mentioned this issue Aug 12, 2020

Remove some no-longer used test code that was missed in recent PRs #11879

Merged

kripken added a commit that referenced this issue Aug 12, 2020

Remove fastcomp-only --separate-asm option. See #11860 (#11869)

c6212ef

SEPARATE_ASM was always just an asm.js feature, and never worked in upstream.

kripken added a commit that referenced this issue Aug 12, 2020

Remove fastcomp-only ALIASING_FUNCTION_POINTERS setting, plus some em…

c88b34d

…scripten.py fastcomp code around it. See #11860

kripken mentioned this issue Aug 12, 2020

Remove fastcomp-only ALIASING_FUNCTION_POINTERS setting #11882

Merged

kripken added a commit that referenced this issue Aug 12, 2020

Remove fastcomp-only FINALIZE_ASM_JS setting. See #11860

22126e5

kripken added a commit that referenced this issue Aug 12, 2020

Remove some WASM_BACKEND usage in src/. See #11860

7d93b8c

kripken added a commit that referenced this issue Aug 12, 2020

Remove more WASM_BACKEND usage in src/. See #11860

20df214

kripken added a commit that referenced this issue Aug 12, 2020

Remove yet more WASM_BACKEND usage in src/. See #11860

b644e12

kripken added a commit that referenced this issue Aug 12, 2020

Remove final WASM_BACKEND usage in src/. See #11860

7919643

kripken mentioned this issue Sep 8, 2020

Remove fastcomp-only RUNNING_JS_OPTS option #12133

Merged

sbc100 added a commit that referenced this issue Sep 8, 2020

Remove the asmjs native optimizer (#12131)

8c6ab93

This is no longer in use since fastcomp removal. See: #11860

kripken added a commit that referenced this issue Sep 8, 2020

Remove fastcomp-only RUNNING_JS_OPTS option (#12133)

bf9352b

See #11860

sbc100 added a commit that referenced this issue Sep 10, 2020

Remove unused separate_asm.py and emlink.py tools

c02a619

These are no longer used or usefull since fastcomp removal. See: #11860

sbc100 mentioned this issue Sep 10, 2020

Remove unused separate_asm.py and emlink.py tools #12142

Merged

sbc100 added a commit that referenced this issue Sep 10, 2020

Remove JS ctor_evaller

2b3b5fa

Also remove functions and modules that were only used by this code. See: #11860

sbc100 mentioned this issue Sep 10, 2020

Remove asm.js ctor_evaller #12144

Merged

sbc100 added a commit that referenced this issue Sep 10, 2020

Remove JS ctor_evaller

720a7fa

Also remove functions and modules that were only used by this code. See: #11860

sbc100 added a commit that referenced this issue Sep 10, 2020

Remove bitcode autodebugger (autodebugger.py)

d33cbf4

This was only used in fastcomp builds. AFAICT the llvm backend uses binaryen passes to do this stuff. See: #11860

sbc100 mentioned this issue Sep 10, 2020

Remove bitcode autodebugger (autodebugger.py) #12145

Merged

sbc100 added a commit that referenced this issue Sep 10, 2020

Remove JS ctor_evaller (#12144)

59296fd

Also remove functions and modules that were only used by this code. See: #11860

sbc100 added a commit that referenced this issue Sep 10, 2020

Remove unused separate_asm.py and emlink.py tools

f9c8c24

These are no longer used or usefull since fastcomp removal. See: #11860

sbc100 added a commit that referenced this issue Sep 10, 2020

Remove bitcode autodebugger (autodebugger.py) (#12145)

fd583b2

This was only used in fastcomp builds. AFAICT the llvm backend uses binaryen passes to do this stuff. See: #11860

sbc100 added a commit that referenced this issue Sep 10, 2020

Remove unused separate_asm.py and emlink.py tools

1c7d9fa

These are no longer used or usefull since fastcomp removal. See: #11860

sbc100 added a commit that referenced this issue Sep 10, 2020

Remove unused separate_asm.py and emlink.py tools (#12142)

56d15e7

These are no longer used or useful since fastcomp removal. See: #11860

sbc100 added a commit that referenced this issue Sep 10, 2020

Remove ASMJS_CODE_FILE internal setting. NFC.

baea929

See: #11860

sbc100 mentioned this issue Sep 10, 2020

Remove ASMJS_CODE_FILE internal setting. NFC. #12158

Merged

sbc100 added a commit that referenced this issue Sep 10, 2020

Remove ASMJS_CODE_FILE internal setting. NFC.

7fd73f3

See: #11860

sbc100 added a commit that referenced this issue Sep 11, 2020

Remove ASMJS_CODE_FILE internal setting. NFC. (#12158)

43396e6

See: #11860

kripken mentioned this issue Sep 11, 2020

Remove STATIC* JS vars and STATIC_BUMP setting #12176

Merged

kripken mentioned this issue Sep 14, 2020

Stop including malloc/free by default #12213

Merged

sbc100 mentioned this issue Sep 24, 2020

Audit all uses of @no_wasm_backend and remove it #12335

Closed

This was referenced Oct 6, 2020

Remove unused methods from shared.JS #12439

Merged

Remove RelooperJumpThreading pass, which was just for fastcomp WebAssembly/binaryen#3199

Merged

kripken added a commit to WebAssembly/binaryen that referenced this issue Oct 8, 2020

Remove RelooperJumpThreading pass, which was just for fastcomp (#3199)

e433611

See emscripten-core/emscripten#11860

stale bot added the wontfix label Aug 21, 2021

stale bot closed this as completed Sep 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fastcomp cleanup post removal #11860

Fastcomp cleanup post removal #11860

sbc100 commented Aug 11, 2020 •

edited by kripken

Loading

kripken commented Aug 11, 2020

sbc100 commented Aug 11, 2020

stale bot commented Aug 21, 2021

Fastcomp cleanup post removal #11860

Fastcomp cleanup post removal #11860

Comments

sbc100 commented Aug 11, 2020 • edited by kripken Loading

kripken commented Aug 11, 2020

sbc100 commented Aug 11, 2020

stale bot commented Aug 21, 2021

sbc100 commented Aug 11, 2020 •

edited by kripken

Loading